Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[FrameworkBundle][Routing] Move RoutingResolverPass to the Routing component#21835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
chalasr commentedMar 2, 2017
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | yes |
| Tests pass? | yes |
| Fixed tickets | n/a |
| License | MIT |
| Doc PR | n/a |
| useSymfony\Component\DependencyInjection\Reference; | ||
| useSymfony\Component\DependencyInjection\ContainerBuilder; | ||
| useSymfony\Component\DependencyInjection\Compiler\CompilerPassInterface; | ||
| @trigger_error(sprintf('The %s class is deprecated since version 3.3 and will be removed in 4.0. UseSymfony\Component\Routing\DependencyInjection\RoutingResolverPass instead.', RoutingResolverPass::class),E_USER_DEPRECATED); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
you can move that line below the "use" and useBaseRoutingResolverPass::class insprintf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Ok I wasn't sure if having it immediately after the namespace has an importance
| "symfony/http-foundation":"~2.8|~3.0", | ||
| "symfony/yaml":"~2.8|~3.0", | ||
| "symfony/expression-language":"~2.8|~3.0", | ||
| "symfony/dependency-injection":"~2.7|~3.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
2.8 instead of 2.7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
fixed
nicolas-grekas left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
👍
7f9ce37 to8b04332Compare| class RoutingResolverPassimplements CompilerPassInterface | ||
| { | ||
| private$resolverServiceId ='routing.resolver'; | ||
| private$loaderTag ='routing.loader'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
default values could be removed here, would prevent a duplication and any sync mistake
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
that's a mistake, fixed. Thanks
fabpot commentedMar 5, 2017
Thank you@chalasr. |
… the Routing component (chalasr)This PR was merged into the 3.3-dev branch.Discussion----------[FrameworkBundle][Routing] Move RoutingResolverPass to the Routing component| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? | yes| Tests pass? | yes| Fixed tickets | n/a| License | MIT| Doc PR | n/aCommits-------32be16b Move RoutingResolverPass to the Routing component