Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[PhpUnitBridge] include expected deprecations in assertion counter#21828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:masterfromxabbuh:assertion-count
Mar 2, 2017

Conversation

@xabbuh
Copy link
Member

QA
Branch?master
Bug fix?no
New feature?yes
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#21786 (comment)
LicenseMIT
Doc PR

We still need to include the changes from#21786 as we cannot increment the number of assertions in thestartTest() method (the PHPUnit test runner resets the counter after the listeners have been executed).

@nicolas-grekas
Copy link
Member

Thank you@xabbuh.

@nicolas-grekasnicolas-grekas merged commitcdcd5ae intosymfony:masterMar 2, 2017
nicolas-grekas added a commit that referenced this pull requestMar 2, 2017
…tion counter (xabbuh)This PR was merged into the 3.3-dev branch.Discussion----------[PhpUnitBridge] include expected deprecations in assertion counter| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | yes| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#21786 (comment)| License       | MIT| Doc PR        |We still need to include the changes from#21786 as we cannot increment the number of assertions in the `startTest()` method (the PHPUnit test runner resets the counter after the listeners have been executed).Commits-------cdcd5ae include expected deprecations in assertion counter
@xabbuhxabbuh deleted the assertion-count branchMarch 2, 2017 12:24
@stof
Copy link
Member

stof commentedMar 6, 2017

I think the issue is thatendTest is actually very late in the process (and after tests are marked as risky). So the assertion count should be registered instartTest (too bad we cannot have a hook at the end of the test execution but before processing the result, to add extra assertions). But this would require registering it inAssert, as the test is rest after the call to the listener

@stof
Copy link
Member

stof commentedMar 6, 2017

My conclusion is that PHPUnit simply does not expect listeners to be a place performing assertions

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

3.3

Development

Successfully merging this pull request may close these issues.

4 participants

@xabbuh@nicolas-grekas@stof@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp