Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[PhpUnitBridge] disable global test listener when not registered#21825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
The global test listener is always initialized to register the clockmock and DNS mock as soon as possible. However, when the listener isregistered locally through the PHPUnit config, it will never beregistered as a listener. In thise case, the state of the locallistener must be reset to correctly report expected deprecation testresults.
Member
fabpot commentedMar 2, 2017
Thank you@xabbuh. |
fabpot added a commit that referenced this pull requestMar 2, 2017
…stered (xabbuh)This PR was merged into the 2.8 branch.Discussion----------[PhpUnitBridge] disable global test listener when not registered| Q | A| ------------- | ---| Branch? | 2.8| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets || License | MIT| Doc PR |The global test listener is always initialized to register the clockmock and DNS mock as soon as possible. However, when the listener isregistered locally through the PHPUnit config, it will never beregistered as a listener. In thise case, the state of the locallistener must be reset to correctly report expected deprecation testresults.Commits-------e068661 disable global test listener when not registered
Contributor
alexpott commentedMay 28, 2019
Whilst trying to use simple-phpunit in Drupal discovered a related issue with listeners registered via the phpunit.xml(.dist) configuration - see#31649 |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The global test listener is always initialized to register the clock
mock and DNS mock as soon as possible. However, when the listener is
registered locally through the PHPUnit config, it will never be
registered as a listener. In thise case, the state of the local
listener must be reset to correctly report expected deprecation test
results.