Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Add deprecation note on routing class parameters#21824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:masterfromlepiaf:inform-deprecation-class-param-routing
Mar 4, 2017
Merged

Add deprecation note on routing class parameters#21824

fabpot merged 1 commit intosymfony:masterfromlepiaf:inform-deprecation-class-param-routing
Mar 4, 2017

Conversation

@lepiaf
Copy link
Contributor

@lepiaflepiaf commentedMar 1, 2017•
edited
Loading

QA
Branch?master
Bug fix?no
New feature?no
BC breaks?no
Deprecations?yes
Tests pass?yes
Fixed tickets#21735
LicenseMIT
Doc PRno

Create PR with note about deprecation of class parameters.

#21739 (comment)

@fabpot
Copy link
Member

Can you also add a note in the Routing component CHANGELOG stating that these parameters are deprecated? And also a note in UPGRADE-3.3.md? Thanks.


* Extending`ConstraintValidatorFactory` is not supported anymore.

* Class parameters in`routing.xml` has been removed
Copy link
Member

@chalasrchalasrMar 1, 2017•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

has =>have. Also I think that the place into which parameters were defined does not matter that much for end users.Class parameters related to routing...,Routing class parameters...?

Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

👍

@stof
Copy link
Member

stof commentedMar 3, 2017

is there a way to trigger a deprecation warning (in a late compiler pass maybe) when these parameters are replaced with values different than the default ones ?

@nicolas-grekas
Copy link
Member

@stof I don't remember doing so when we removed such params in 3.0, did we? Not sure it's really worth it.

@nicolas-grekasnicolas-grekas added this to the3.3 milestoneMar 4, 2017
@fabpot
Copy link
Member

Thank you@lepiaf.

@fabpotfabpot merged commit5b0641e intosymfony:masterMar 4, 2017
fabpot added a commit that referenced this pull requestMar 4, 2017
This PR was merged into the 3.3-dev branch.Discussion----------Add deprecation note on routing class parameters| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | no| BC breaks?    | no| Deprecations? | yes| Tests pass?   | yes| Fixed tickets |#21735| License       | MIT| Doc PR        | noCreate PR with note about deprecation of class parameters.#21739 (comment)Commits-------5b0641e Add deprecation note on routing class parameters
@fabpotfabpot mentioned this pull requestMay 1, 2017
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@chalasrchalasrchalasr left review comments

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

3.3

Development

Successfully merging this pull request may close these issues.

6 participants

@lepiaf@fabpot@stof@nicolas-grekas@chalasr@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp