Having a simpler API is a good idea.

But I'm really not a fan of the magic API, which returns a nested array when you give 0 arguments or >2, but a flat array when you pass 1 argument. This is too magic.

btw, to get some types only, an array would be better than a variadic function IMO. Twig does not have the spread operator, and does not have acall_user_func_array equivalent to allow building arguments dynamically

I've replaced the variadic arguments by an array:

@stof I take your comment into consideration, but in this case, instead of "magic API" I think it's "smart/flexible API". It's similar to when Symfony lets you pass a string to a config option that needs an array and does the string -> array conversion automatically.

I think that returning a nested array when you ask for the flash messages of a single type is cumbersome:

{# you would need to use this...#}{%formessagein app.flashes('notice')['notice'] %}    <divclass="alert alert-notice">        {{message }}    </div>{%endfor %}{# ... or this ...#}{%fortype,messagesin app.flashes('notice') %}    {%formessageinmessages %}        <divclass="alert alert-notice">            {{message }}        </div>    {%endfor %}{%endfor %}{# ... instead of this:#}{%formessagein app.flashes('notice') %}    <divclass="alert alert-notice">        {{message }}    </div>{%endfor %}

But I'm open to other comments and opinions about this. Let's work together to make a great API that doesn't feel magic! Thanks.

Not sure about the mixed api.. i could live with it i guess. In twig context it's probably less an issue, and once you know it you're good to go :)

Some other thoughts

• getFlashes($type = null) either all types nested, or a single type flat
• getFlashes(array $types = null) for nested /getFlashesFor(array $types = null) for flat
• {{ message.type ~ message.value }} flat with a nested message structure

Hopefully I have the code right this time. The idea is:

• If you pass a string, you get a simple array with just those messages
• If you pass an array, you get an array of messages
• Otherwise, you get all messages ... except when the session hasn't started, where you get an empty array

👍

Thank you@javiereguiluz.

Hey@javiereguiluz, can you explain to me, why starting session once getting flash messages is not an intended behaviour, please?

I had given scenario: on 1st request, flashmessage and redirect user; on 2nd request, I haveapp.flashes('message') in Twig, but it returns nothing, because I do not start session anywhere, I initially want it to exist, since I want to retrieve this flash, right?

@Albert221 this has been fixed in this PR:https://github.com/symfony/symfony/pull/25077/files