Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[DI][Router][DX] Invalidate routing cache when container parameters changed#21767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
fabpot merged 1 commit intosymfony:masterfromogizanagi:feature/container_parameters_resourceMar 5, 2017
Merged
[DI][Router][DX] Invalidate routing cache when container parameters changed#21767
fabpot merged 1 commit intosymfony:masterfromogizanagi:feature/container_parameters_resourceMar 5, 2017
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Member
weaverryan commentedMar 4, 2017
👍 Nice work! |
| private $parameters; | ||
| /** | ||
| * @param array $parameters The container parameters values to track |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I would remove "values" here.
| return false; | ||
| } | ||
| } | ||
| } catch (ParameterNotFoundException $exception) { |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Why not callinghasParameter() instead?
ContributorAuthor
ogizanagi commentedMar 5, 2017
Thanks for the review.@xabbuh's comments addressed. |
Member
xabbuh commentedMar 5, 2017
👍 |
Member
fabpot commentedMar 5, 2017
Thank you@ogizanagi. |
fabpot added a commit that referenced this pull requestMar 5, 2017
…er parameters changed (ogizanagi)This PR was merged into the 3.3-dev branch.Discussion----------[DI][Router][DX] Invalidate routing cache when container parameters changed| Q | A| ------------- | ---| Branch? | master| Bug fix? | yes| New feature? | yes| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#21426| License | MIT| Doc PR | N/ASupersedes#21443 but only for master.Indeed, this implementation uses a new feature: a `ContainerParametersResource` which compares cached containers parameters (collected at some point, here by the `Router`) with current ones in the container.On the contrary of the previous PR targeting 2.7, this will only invalidate routing cache when parameters actually used in the routes changed and will avoid always rebuilding the routing cache when the container is rebuilt, just to catch the edge case of someone modifying a parameter.Commits-------fad4d9e [DI][Router][DX] Invalidate routing cache when container parameters changed
Merged
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
BugDependencyInjectionDXDX = Developer eXperience (anything that improves the experience of using Symfony) FeatureRoutingStatus: Needs Review
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Supersedes#21443 but only for master.
Indeed, this implementation uses a new feature: a
ContainerParametersResourcewhich compares cached containers parameters (collected at some point, here by theRouter) with current ones in the container.On the contrary of the previous PR targeting 2.7, this will only invalidate routing cache when parameters actually used in the routes changed and will avoid always rebuilding the routing cache when the container is rebuilt, just to catch the edge case of someone modifying a parameter.