Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Remove some class parameters related to Routing#21739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
lepiaf wants to merge1 commit intosymfony:masterfromlepiaf:remove-class-param-routing
Closed

Remove some class parameters related to Routing#21739

lepiaf wants to merge1 commit intosymfony:masterfromlepiaf:remove-class-param-routing

Conversation

@lepiaf
Copy link
Contributor

@lepiaflepiaf commentedFeb 23, 2017•
edited by javiereguiluz
Loading

QA
Branch?master
Bug fix?no
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#21735
LicenseMIT
Doc PRno

ro0NL reacted with thumbs up emoji
Copy link
Member

@javiereguiluzjaviereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

👍

@xabbuh
Copy link
Member

I bet there will be users out there who rely on these parameters. At least, we should document this in the upgrade file.

@Tobion
Copy link
Contributor

I'm totally in favor of removing this. But are you sure you want to do that BC break in 3.x?

@fabpot
Copy link
Member

Let's keep that one for 4.0.@lepiaf Can you create a new PR on master (aka 3.3) with just a note in the UPGRADE/CHANGELOG file that those parameters are deprecated and will be removed in 4.0?

@xabbuhxabbuh modified the milestones:4.0,3.3Mar 1, 2017
@lepiaf
Copy link
ContributorAuthor

Should I create CHANGELOG-4.0.md file ? It does not exists yet.

@xabbuh
Copy link
Member

@lepiaf The global changelog files are generated automatically. You can just add a new entry to the changelog file of the Routing component.

fabpot added a commit that referenced this pull requestMar 4, 2017
This PR was merged into the 3.3-dev branch.Discussion----------Add deprecation note on routing class parameters| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | no| BC breaks?    | no| Deprecations? | yes| Tests pass?   | yes| Fixed tickets |#21735| License       | MIT| Doc PR        | noCreate PR with note about deprecation of class parameters.#21739 (comment)Commits-------5b0641e Add deprecation note on routing class parameters
symfony-splitter pushed a commit to symfony/routing that referenced this pull requestMar 4, 2017
This PR was merged into the 3.3-dev branch.Discussion----------Add deprecation note on routing class parameters| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | no| BC breaks?    | no| Deprecations? | yes| Tests pass?   | yes| Fixed tickets |symfony/symfony#21735| License       | MIT| Doc PR        | noCreate PR with note about deprecation of class parameters.symfony/symfony#21739 (comment)Commits-------5b0641ebe1 Add deprecation note on routing class parameters
@fabpot
Copy link
Member

Closing in favor of#21824

@fabpotfabpot closed thisMar 4, 2017
@lepiaflepiaf deleted the remove-class-param-routing branchMarch 4, 2017 22:32
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@javiereguiluzjaviereguiluzjaviereguiluz approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

4.0

Development

Successfully merging this pull request may close these issues.

7 participants

@lepiaf@xabbuh@Tobion@fabpot@javiereguiluz@nicolas-grekas@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp