NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[Security] User refreshment from identical users provider type#21737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

mykiwi wants to merge2 commits intosymfony:2.7frommykiwi-forks:pr-12465-providers

Closed

[Security] User refreshment from identical users provider type#21737

mykiwi wants to merge2 commits intosymfony:2.7frommykiwi-forks:pr-12465-providers

Conversation

Copy link

Contributor

mykiwi commentedFeb 23, 2017

Q	A
Branch?	2.7
Bug fix?	yes
New feature?	no
BC breaks?	no
Deprecations?	no
Tests pass?	?
Fixed tickets	#12465
License	MIT

#12465 rebase with fixes.

[Security] User refreshment from identical users provider type

c4bd582

carsonbot added Status: Needs Review Security Bug labels

Feb 23, 2017

fixes

1e3df19

mykiwi force-pushed thepr-12465-providers branch from8c38f6e to1e3df19Compare

February 23, 2017 17:00

Copy link

Member

xabbuh commentedFeb 23, 2017

Shouldn't we rather take the user provider that was configured for the active firewall?

Copy link

ContributorAuthor

mykiwi commentedFeb 24, 2017

I don't know well this part. I would need more details to do it.

nicolas-grekas added this to the2.7 milestone

Feb 25, 2017

xabbuh mentioned this pull request

Feb 27, 2017

[SecurityBundle] only pass relevant user provider#21791

Merged

Copy link

Member

xabbuh commentedFeb 27, 2017

@mykiwi Sorry for not coming back with more details. I had to look into the code myself and I propose to solve this in a more simple way. Therefore, I am closing here in favour of#21791.

xabbuh closed this

Feb 27, 2017

fabpot added a commit that referenced this pull request

Feb 28, 2017

bug#21791[SecurityBundle] only pass relevant user provider (xabbuh)

eb750be

This PR was merged into the 2.7 branch.Discussion----------[SecurityBundle] only pass relevant user provider| Q             | A| ------------- | ---| Branch?       | 2.7| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#4498,#12465,#20401,#21737| License       | MIT| Doc PR        |There is no need for the context listener to be aware of all the configured user providers. It must only use the provider for the current firewall (the one identified by the context key passed to the constructor) to refresh the user from the session.Commits-------d97e07f [SecurityBundle] only pass relevant user provider