Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[3.4] Deprecations regarding use of service locators/getter injection#21710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@chalasr
Copy link
Member

@chalasrchalasr commentedFeb 22, 2017
edited
Loading

QA
Branch?3.4
Bug fix?no
New feature?no
BC breaks?no
Deprecations?yes
Tests pass?yes
Fixed ticketsn/a
LicenseMIT
Doc PRn/a

In order to don't do it twice, this includes the deprecations for#21625.
Targets 3.4 (or more if the experimental period for service locators/getter injection is prolonged).

@chalasrchalasr changed the titleRemove container injections deprecations[3.4] Deprecations regarding use of service locators/getter injectionFeb 22, 2017
@ogizanagi
Copy link
Contributor

Targets 3.4 (or more if the experimental period for service locators/getter injection is prolonged).

I doubt it will be more anyway, as 3.4 is the last release for Symfony 3.
Can experimental features stay experimental in a new major release?

@chalasrchalasrforce-pushed theremove-container-injections-deprecations branch fromd10bb99 tod8f02e4CompareFebruary 22, 2017 17:45
@chalasr
Copy link
MemberAuthor

@ogizanagi Given "experimental" doesn't fit with semver and considering the following statement:

The core team can decide to extend the experimental period for another minor version on a case by case basis.

I would say yes.

chalasrand others added2 commitsFebruary 22, 2017 18:56
[TwigBundle] Replace container by service locator in ContainerAwareRuntimeLoader[HttpKernel] Replace container by service locator in LazyLoadingFragmentHandlerKeep legacy feature working
@chalasrchalasrforce-pushed theremove-container-injections-deprecations branch fromd8f02e4 to34eeffbCompareFebruary 22, 2017 17:56
@nicolas-grekas
Copy link
Member

This is going to be a nightmare to track to me... Except for the UPGRADE notes, I'd prefer to have the code side be implemented right into the PR introducing the new proposed way of things so that the test suite can spot any missing upgrade of the code base.

@nicolas-grekas
Copy link
Member

nicolas-grekas commentedFeb 25, 2017
edited
Loading

ping@fabpot (another option being to remove the experimental flag to feats that have already proven their usefulness in 3.3)

@nicolas-grekasnicolas-grekas added this to the3.x milestoneFeb 25, 2017
@chalasrchalasr deleted the remove-container-injections-deprecations branchFebruary 26, 2017 11:35
fabpot added a commit that referenced this pull requestFeb 26, 2017
…ument type (chalasr)This PR was merged into the 3.3-dev branch.Discussion----------[DI] Remove experimental status from service-locator argument type| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#21625 (comment),#21625 (comment),#21710| License       | MITThe `service-locator` argument type is not controversial to me. We know its scope, nothing really surprising, just a map of services to be lazily loaded like `iterator` is (which is not experimental) but keyed.About its api, it's just PSR-11 restricted to objects, nothing that can't be changed safely in the future.As stated in#21625 (comment), it proven its usefulness already. I think what we were looking for by flagging it experimental is just to see it in action, we've 3 opened PRs for that (#21625,#21690,#21730).This allows introducing deprecations for making use of the feature in the core, thus unlocks#21625 and#21690.Commits-------46dc47a [DI] Remove experimental status from service-locator argument type
@nicolas-grekasnicolas-grekas modified the milestones:3.x,3.3Mar 24, 2017
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

3.3

Development

Successfully merging this pull request may close these issues.

4 participants

@chalasr@ogizanagi@nicolas-grekas@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp