Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[SecurityBundle] simplified code#21709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
xabbuh commentedFeb 22, 2017
We need to be explicit about the supported versions (should be |
| $voters =call_user_func_array('array_merge',$voters); | ||
| if (!$voters) { | ||
| thrownewLogicException('No security voters found. You need to tag at least one with "security.voter"'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
this exception is gone. Is it expected ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
No, that's a mistake.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
fixed, test added
9961ccb toe713cebComparee713ceb to512742bCompareThis PR was merged into the 3.2 branch.Discussion----------[SecurityBundle] simplified code| Q | A| ------------- | ---| Branch? | 3.2| Bug fix? | no| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | n/a| License | MIT| Doc PR | n/aSimplified code for 3.2 (followup to#21679)Commits-------512742b [SecurityBundle] simplified code
Simplified code for 3.2 (followup to#21679)