Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Yaml] fix DUMP_EMPTY_ARRAY_AS_SEQUENCE flag value#21678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
xabbuh commentedFeb 20, 2017
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | |
| License | MIT |
| Doc PR |
| constDUMP_MULTI_LINE_LITERAL_BLOCK =128; | ||
| constPARSE_CONSTANT =256; | ||
| constDUMP_EMPTY_ARRAY_AS_SEQUENCE =512; | ||
| constDUMP_EMPTY_ARRAY_AS_SEQUENCE =1024; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
what about reversingDUMP_EMPTY_ARRAY_AS_SEQUENCE andPARSE_CUSTOM_TAGS values? It would look more natural imo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
IMO it's not worth it. Otherwise we begin to swap values every time we introduce new flags.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
is it an issue really?
fabpot commentedFeb 20, 2017
Thank you@xabbuh. |
This PR was merged into the 3.3-dev branch.Discussion----------[Yaml] fix DUMP_EMPTY_ARRAY_AS_SEQUENCE flag value| Q | A| ------------- | ---| Branch? | master| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets || License | MIT| Doc PR |Commits-------3953d76 fix DUMP_EMPTY_ARRAY_AS_SEQUENCE flag value