Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[RFC][PHPUnitBridge] Cross compatibility between PHPUnit 5 and 6#21668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Taluu commentedFeb 18, 2017
You should also check that the class you are declaring doesn't exist (and that the bc one exists too). |
peterrehm commentedFeb 19, 2017
@Taluu As far as I investigated yesterday that should not be a Problem as composer makes it possible to have multiple classes within the same namespace. And since the FC layer is needed when the namespaceless classes are available that might be a viable solution. But this is more a POC so far to see if this is even possible this way. I am not sure why |
Jean85 commentedFeb 20, 2017
Thanks for this PR! Unfortunately, this kind of approach was prev. rejected, seethis comment:
PS: you should add#21125 as a fixed ticket. |
peterrehm commentedFeb 20, 2017
Mhm, then I can only think of making a bridge version which is only PHPUnit 6 compatible or move the FC layer to a separate repository. As I understood@nicolas-grekas in#21663 such change as this can anyway go only into 3.3? |
Jean85 commentedFeb 20, 2017
In my PR I wrote the FC layer in the Bridge. The FC classes expanded PHPUnit's. |
peterrehm commentedFeb 20, 2017
But this breaks the Interface and I think that is waht you were stuck with? |
Jean85 commentedFeb 20, 2017
Yes, you're right. I think that is the current impasse. |
nicolas-grekas commentedFeb 21, 2017
Closing on favor of#21694 |
This PR was merged into the 3.3-dev branch.Discussion----------[Bridge/PhpUnit] Add PHPUnit 6 support| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#21125| License | MIT| Doc PR | -This PR makes our phpunit bridge compatible with all namespaced versions of phpunit, from 4.8.35 to 6.It takes another approach than#21668 and#21221, thus replaces them.Tested locally : tests pass when using phpunit 5.7, and fails with v6.0 because our own test suite is not yet compatible with it - but at least it runs nice.If this were handled as usual Symfony component, we would consider some changes to be BC breaks. But in this specific case - a phpunit bridge - it makes no sense to me to apply the bc policy here. I added `@final` and `@internal` annotations to make this clearer.Commits-------9e0745c [Bridge/PhpUnit] Add PHPUnit 6 support
Uh oh!
There was an error while loading.Please reload this page.
Based on#21221. /cc@Jean85.
First experiment with a FC layer for PHPUnit.