Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
add missing changelog for deprecated strict attribute#21662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
nicolas-grekas commentedFeb 18, 2017 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
should we also enhance/instead the deprecation message in the code? |
dbu commentedFeb 18, 2017
if the flag can actually just be removed, that would be developer friendly i think. however, i just tried to fix this and with the head branch of symfony/symfony 2.8 i still get the "Scope Widening Injection detected". i understood that the latest symfony 2.8 was fixed to allow removing the parameter? |
nicolas-grekas commentedFeb 19, 2017
only master has the deprecation about the strict attribute - not sure why you talk about 2.8 :) |
dbu commentedFeb 19, 2017
i maintain bundles that support both 2.8 and 3.#21058 (comment) made me think we can just remove the attribute but that fails on 2.8 while working in 3:symfony-cmf/routing-bundle#390 |
xabbuh left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
👍
nicolas-grekas left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
👍
fabpot commentedFeb 20, 2017
Thank you@dbu. |
This PR was merged into the 3.3-dev branch.Discussion----------add missing changelog for deprecated strict attribute| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | -| License | MIT| Doc PR | -since#21058, 3.3 triggers a deprecation when using the strict attribute. luckily wouter managed to find the reason and we figured out we can simply delete the attribute. having an upgrade file entry would make it easier to find the reason for the deprecation and be sure what to do. (assuming i understood the implications correctly)Commits-------2c5f879 add missing changelog for deprecated strict attribute
since#21058, 3.3 triggers a deprecation when using the strict attribute. luckily wouter managed to find the reason and we figured out we can simply delete the attribute. having an upgrade file entry would make it easier to find the reason for the deprecation and be sure what to do. (assuming i understood the implications correctly)