Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[DoctrineBridge] Fixed validating custom doctrine type columns#21656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:3.2fromdmaicher:fix-validation-custom-type
Feb 21, 2017

Conversation

@dmaicher
Copy link
Contributor

@dmaicherdmaicher commentedFeb 18, 2017•
edited
Loading

QA
Branch?3.1
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#21619
LicenseMIT
Doc PR-

Thisfixes#21619 by not assuming the invalid$value is a Doctrine entity if its an object

@xabbuh
Copy link
Member

Symfony 3.1 doesn't receive bug fixes any more. Can you rebase on the3.2 branch and change the target branch accordingly?

@dmaicher
Copy link
ContributorAuthor

Ah sorry you are right. Will rebase it later today 😉

@dmaicherdmaicherforce-pushed thefix-validation-custom-type branch fromc642345 to70d962cCompareFebruary 20, 2017 10:37
@dmaicherdmaicher changed the base branch from3.1 to3.2February 20, 2017 10:37
@dmaicherdmaicherforce-pushed thefix-validation-custom-type branch from70d962c toad59370CompareFebruary 20, 2017 10:38
@dmaicher
Copy link
ContributorAuthor

@xabbuh done 😉

Copy link
Member

@xabbuhxabbuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

👍 We could use theclass constants instead of strings, but that's not a blocker IMO.

Status: Reviewed

@fabpot
Copy link
Member

Thank you@dmaicher.

@fabpotfabpot merged commitad59370 intosymfony:3.2Feb 21, 2017
fabpot added a commit that referenced this pull requestFeb 21, 2017
…umns (dmaicher)This PR was merged into the 3.2 branch.Discussion----------[DoctrineBridge] Fixed validating custom doctrine type columns| Q             | A| ------------- | ---| Branch?       | 3.1| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#21619| License       | MIT| Doc PR        | -Thisfixes#21619 by not assuming the invalid `$value` is a Doctrine entity if its an objectCommits-------ad59370 [DoctrineBridge] Fixed validating custom doctrine type columns
@fabpotfabpot mentioned this pull requestMar 9, 2017
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@xabbuhxabbuhxabbuh left review comments

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dmaicher@xabbuh@fabpot@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp