NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[DependencyInjection] fix support of inherited tags in child services definitions.#21629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

hhamon wants to merge1 commit intosymfony:masterfromhhamon:fix-inherit-tags

Closed

[DependencyInjection] fix support of inherited tags in child services definitions.#21629

hhamon wants to merge1 commit intosymfony:masterfromhhamon:fix-inherit-tags

Conversation

Copy link

Contributor

hhamon commentedFeb 16, 2017

Q	A
Branch?	master
Bug fix?	yes
New feature?	no
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets	~
License	MIT
Doc PR	~

carsonbot added Status: Needs Review DependencyInjection Bug labels

Feb 16, 2017

hhamon force-pushed thefix-inherit-tags branch 2 times, most recently from41b5a85 to4665128Compare

February 16, 2017 15:02

Copy link

ContributorAuthor

hhamon commentedFeb 16, 2017

This PR is also related to#21530.

[DependencyInjection] run the ResolveDefinitionTemplatesPass compiler…

e7824fc

… pass very early first to support inherited tags in services definitions.

hhamon force-pushed thefix-inherit-tags branch from4665128 toe7824fcCompare

February 16, 2017 15:59

Copy link

Member

nicolas-grekas commentedFeb 17, 2017

Instead of running ResolveDefinitionTemplatesPass twice, we need a new ResolveDefinitionInheritancePass compiler pass, that does only copy tags from parents to children when required. This should preserve the ChildDefinition objects because at this stage it still makes sense to have them untouched. Will remove any potential BC break that resolving definition templates might create also.