Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Improve tracking of environment variables in the case of private services#21607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@tgalopin
Copy link
Contributor

QA
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#21273
LicenseMIT

Recently, I stumbled upon an issue with environment variables that I had troubles to understand. Here it is:

I have two environment variables, defined in myparameters.yml with a default value of empty:

parameters:env(MAILJET_PUBLIC_KEY):''env(MAILJET_PRIVATE_KEY):''

I use these variables only in a private service:

<serviceid="app.mailjet.transport"class="AppBundle\Mailjet\MailjetApiTransport"public="false">    <argumenttype="service"id="csa_guzzle.client.mailjet_api"/>    <argument>%env(MAILJET_PUBLIC_KEY)%</argument>    <argument>%env(MAILJET_PRIVATE_KEY)%</argument></service>

This private service is not used by any other service for the moment.

As the service is private and not used by any other service, theRemoveUnusedDefinitionsPass removes it from the container. However, when the container dumper dumps the container, it checks if the environment variable was dumped. As the service is now gone, an expection is thrown (EnvParameterException, Incompatible use of dynamic environment variables "MAILJET_PUBLIC_KEY", "MAILJET_PRIVATE_KEY" found in parameters.).

Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

👍

Copy link
Member

@stofstof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

👍

@nicolas-grekas
Copy link
Member

Thank you@tgalopin.

@nicolas-grekasnicolas-grekas merged commitf380ba3 intosymfony:3.2Feb 14, 2017
nicolas-grekas added a commit that referenced this pull requestFeb 14, 2017
…rivate services (tgalopin)This PR was merged into the 3.2 branch.Discussion----------Improve tracking of environment variables in the case of private services| Q             | A| ------------- | ---| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#21273| License       | MITRecently, I stumbled upon an issue with environment variables that I had troubles to understand. Here it is:I have two environment variables, defined in my `parameters.yml` with a default value of empty:``` yamlparameters:    env(MAILJET_PUBLIC_KEY): ''    env(MAILJET_PRIVATE_KEY): ''```I use these variables only in a private service:``` xml<service public="false">    <argument type="service"/>    <argument>%env(MAILJET_PUBLIC_KEY)%</argument>    <argument>%env(MAILJET_PRIVATE_KEY)%</argument></service>```This private service is not used by any other service for the moment.As the service is private and not used by any other service, the `RemoveUnusedDefinitionsPass` removes it from the container. However, when the container dumper dumps the container, it checks if the environment variable was dumped. As the service is now gone, an expection is thrown (`EnvParameterException, Incompatible use of dynamic environment variables "MAILJET_PUBLIC_KEY", "MAILJET_PRIVATE_KEY" found in parameters.`).Commits-------f380ba3 Improve tracking of environment variables in the case of private services
@tgalopintgalopin deleted the fix-env-vars-tracking-private branchFebruary 14, 2017 12:28
@fabpotfabpot mentioned this pull requestFeb 17, 2017
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@stofstofstof approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tgalopin@nicolas-grekas@stof@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp