Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Validator] property constraints can be added in child classes#21592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
+90 −20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Member
fabpot commentedFeb 12, 2017
Looks like tests are broken. |
MemberAuthor
xabbuh commentedFeb 13, 2017
tests fixed |
Member
fabpot commentedFeb 13, 2017
Thank you@xabbuh. |
fabpot added a commit that referenced this pull requestFeb 13, 2017
…sses (angelk, xabbuh)This PR was merged into the 2.7 branch.Discussion----------[Validator] property constraints can be added in child classes| Q | A| ------------- | ---| Branch? | 2.7| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#21538,#21567| License | MIT| Doc PR |This reverts the changes done in#21053 (and applies the test written by@angelk in#21538). I think trying to "fix"#15950 with the changes from#21053 was a mistake. Child classes should be able to refine validation constraints (I basically agree with@ro0NL's reasoning in#21567 (comment).Commits-------9513a8a property constraints can be added in child classesa266ff7 added test for staticClassLoader in LazyLoadingMetadatafactory
Contributor
ro0NL commentedFeb 14, 2017
MemberAuthor
xabbuh commentedFeb 14, 2017
@ro0NL Indeed, thanks for the reminder. |
Merged
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts the changes done in#21053 (and applies the test written by@angelk in#21538). I think trying to "fix"#15950 with the changes from#21053 was a mistake. Child classes should be able to refine validation constraints (I basically agree with@ro0NL's reasoning in#21567 (comment).