Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[WebProfilerBundle] Readd Symfony version status in the toolbar#21584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
[WebProfilerBundle] Readd Symfony version status in the toolbar#21584
Uh oh!
There was an error while loading.Please reload this page.
Conversation
javiereguiluz left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
👍
@wouterj I'm sorry about this ... but as you said, it wasn't done on purpose. I wanted to remove the<a> tosymfony.com because it's frustrating to click on that element and exit your application and go to symfony.com ... but the description about the version is definitely useful!
nicolas-grekas commentedFeb 11, 2017
Thank you@wouterj. |
…olbar (wouterj)This PR was merged into the 2.8 branch.Discussion----------[WebProfilerBundle] Readd Symfony version status in the toolbar| Q | A| ------------- | ---| Branch? | 2.8| Bug fix? | yes| New feature? | yes| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | -| License | MIT| Doc PR | -The Symfony version status (*"This Symfony version will no longer receive security fixes."* and the like) was no longer shown in the toolbar. This was removed in9d89841 , but the commit description isn't that describing. I guess it's not done on purpose.I think having this information is crucial for this feature to work: A yellow version doesn't mean anything specific, unless I see "This Symfony will only receive security fixes"./cc@javiereguiluzCommits-------d714c7e Readd Symfony version status in the toolbar
Uh oh!
There was an error while loading.Please reload this page.
The Symfony version status ("This Symfony version will no longer receive security fixes." and the like) was no longer shown in the toolbar. This was removed in9d89841 , but the commit description isn't that describing. I guess it's not done on purpose.
I think having this information is crucial for this feature to work: A yellow version doesn't mean anything specific, unless I see "This Symfony will only receive security fixes".
/cc@javiereguiluz