Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Security] LdapUserProvider should not throw an exception if the UID key does not exist in an LDAP entry#21579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Closed
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
…t exist in the response
ContributorAuthor
csarrazi commentedFeb 10, 2017
Tests are not yet added, I will add them a bit later. |
ContributorAuthor
csarrazi commentedFeb 10, 2017
Added tests. Failures are not related to this PR. |
ContributorAuthor
csarrazi commentedFeb 10, 2017
Ping@nicolas-grekas |
Member
fabpot commentedFeb 11, 2017
merging into 3.2 as 3.1 is not maintained anymore. |
Member
fabpot commentedFeb 11, 2017
Thank you@csarrazi. |
fabpot added a commit that referenced this pull requestFeb 11, 2017
…if the UID key does not exist in an LDAP entry (csarrazi)This PR was submitted for the 3.1 branch but it was merged into the 3.2 branch instead (closes#21579).Discussion----------[Security] LdapUserProvider should not throw an exception if the UID key does not exist in an LDAP entry| Q | A| ------------- | ---| Branch? | 3.1+| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#21577| License | MIT| Doc PR |This ticket shouldfix#21577, which was introduced by commit6641b79LdapUserProvider should not throw an exception if the uid key does not exist in the entry.Commits-------ee4d9a7 [Security] LdapUserProvider should not throw an exception if the UID key does not exist in an LDAP entry
Merged
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
This ticket shouldfix#21577, which was introduced by commit6641b79
LdapUserProvider should not throw an exception if the uid key does not exist in the entry.