Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[DoctrineBridge] make sure that null can be the invalid value#21562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
xabbuh commentedFeb 7, 2017
| Q | A |
|---|---|
| Branch? | 2.7 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #21554 |
| License | MIT |
| Doc PR |
| protected$id; | ||
| /** @Column(type="string") */ | ||
| /** @Column(type="string", nullable=true) */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Maybe this deserves aDoubleNullableNameEntity to keep testing the old config and be sure to prevent any regressions for both cases. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
good idea, done
xabbuh commentedFeb 8, 2017
This needs more work (see#21554 (comment)). Status: Needs work |
xabbuh commentedFeb 9, 2017
#21554 (comment) addressed Status: Needs Review |
nicolas-grekas left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
👍
fabpot commentedFeb 12, 2017
Thank you@xabbuh. |
…lue (xabbuh)This PR was merged into the 2.7 branch.Discussion----------[DoctrineBridge] make sure that null can be the invalid value| Q | A| ------------- | ---| Branch? | 2.7| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#21554| License | MIT| Doc PR |Commits-------c3702c2 make sure that null can be the invalid value