shouldn't we rather avoid all the useless info instead of overwriting the existing ones ?

shouldn't we rather avoid all the useless info instead of overwriting the existing ones ?

The things is: it's hard to know when property X or property Y has been added in the extension. So If we want to avoid overwriting, we should check for each property if it has been defined before.

WDYT?

Well, you are switching the prefix globally anyway, which implies that they all changed together.

Indeed. But anyway$array += [] does not overwrite the initial value. So IMHO, it's not an issue. I just specifically, overwrite some properties, to enchance the display.

But just to be sure I understand, you propose something like that:

// Recent version of the extension already expose internal propertiesif (isset($a["\x00AMQPConnection\x00login"])) {$a += [                Caster::PREFIX_VIRTUAL.'isConnected' =>$c->isConnected(),            ];return$a;        }$prefix = Caster::PREFIX_VIRTUAL;// BC layer in the amqp libif (method_exists($c,'getReadTimeout')) {$timeout =$c->getReadTimeout();        }else {$timeout =$c->getTimeout();        }$a +=array($prefix.'isConnected' =>$c->isConnected(),$prefix.'login' =>$c->getLogin(),$prefix.'password' =>$c->getPassword(),$prefix.'host' =>$c->getHost(),$prefix.'vhost' =>$c->getVhost(),$prefix.'port' =>$c->getPort(),$prefix.'read_timeout' =>$timeout,        );return$a;

@stof I updated my PR according to your comments.

👍

Btw, don't we need to update some tests ?

Btw, don't we need to update some tests ?

This part is not tested... :/

Thank you@lyrixx.