Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[FrameworkBundle] Wire ArrayCache for annotation reader at bootstrap#21556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| if ($container->hasAlias($provider =$tags['annotations.cached_reader'][0]['provider'])) { | ||
| $provider = (string)$container->getAlias($provider); | ||
| } | ||
| $container->set('annotations.cached_reader',null); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
aren't we deprecating this ?
nicolas-grekasFeb 7, 2017 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
not in#21533 (methodMap is empty in ContainerBuilder), but in#19668 yes - yet I think we should not merge itas explained implicitly :)
tristanbes commentedFeb 8, 2017 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
This patch seems to fix this issue:#21559 that is present on v3.2.3 As you can see on blackfire: This patch still have a +2,39% negative impact on performance, but it's still better than +2020% of negative impact :-) |
lubomir-haralampiev commentedFeb 9, 2017
also fixes the#21576 Thanks |
fabpot commentedFeb 12, 2017
Thank you@nicolas-grekas. |
… bootstrap (nicolas-grekas)This PR was merged into the 3.2 branch.Discussion----------[FrameworkBundle] Wire ArrayCache for annotation reader at bootstrap| Q | A| ------------- | ---| Branch? | 3.2| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#21549| License | MIT| Doc PR | -Related to#21381 which disabled any cache at bootstrap.Instead, this wires ArrayCache during bootstrapping, then swaps the cache provider for the real one.Commits-------f90f53e [FrameworkBundle] Wire ArrayCache for annotation reader at bootstrap
Related to#21381 which disabled any cache at bootstrap.
Instead, this wires ArrayCache during bootstrapping, then swaps the cache provider for the real one.