Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[FrameworkBundle] Add missing autowiring aliases for common interfaces#21517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
113262c toe283263Comparee283263 toc3a2141Comparenicolas-grekas commentedFeb 3, 2017
should we add LoggerInterface also? or do we consider it should be done on monolog bundle? |
chalasr commentedFeb 3, 2017
Not sure but I would say yes so each bundle is responsible for supporting autowiring for its services |
nicolas-grekas left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
👍
fabpot commentedFeb 3, 2017
Thank you@chalasr. |
…ommon interfaces (chalasr)This PR was merged into the 3.3-dev branch.Discussion----------[FrameworkBundle] Add missing autowiring aliases for common interfaces| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | -| License | MIT| Doc PR | n/aCommits-------c3a2141 [FrameworkBundle] Add more autowiring aliases
| returnarray( | ||
| newFrameworkBundle(), | ||
| newSecurityBundle(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Why is this test located in the FrameworkBundle and not in the SecurityBundle?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@xabbuh I thought about that but it was simpler to integrate a new test here than duplicating the whole test case on the SecurityBundle. Does it hurt?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I missed that, but indeed, that's not good.@chalasr Can you move it to SecurityBundle?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Ok I'll do
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
See#21522
chalasr commentedFeb 3, 2017
@nicolas-grekas Seesymfony/monolog-bundle#203 for LoggerInterface |
stof commentedFeb 3, 2017
I would also ensure that |
This PR was merged into the 3.3-dev branch.Discussion----------[SecurityBundle] Add AutowiringTypesTest| Q | A| ------------- | ---| Branch? | master| Tests pass? | yes| Fixed tickets |#21517 (comment)| License | MITCommits-------d1001d4 [SecurityBundle] Add AutowiringTypesTest
Uh oh!
There was an error while loading.Please reload this page.