Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[BrowserKit] ignore invalid cookies expires date format#21462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:2.7fromxabbuh:issue-15656
Jan 30, 2017

Conversation

@xabbuh
Copy link
Member

QA
Branch?2.7
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#15656
LicenseMIT
Doc PR

@stof
Copy link
Member

This looks weird to me. The issue says to ignore the cookie, not to ignore only its date

@xabbuh
Copy link
MemberAuthor

Not sure what you mean. The issue description contains this quote from the RFC:

If the attribute-value failed to parse as a cookie date, ignore the cookie-av.

Maybe I misinterpret that part, but IIUCcookie-av means cookie argument value, but the entire cookie.

@stof
Copy link
Member

ah sorry, I misread it

Copy link
Member

@javiereguiluzjaviereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I guess we should also update the constructor of this class, where you can find:

if (null !==$expires) {$timestampAsDateTime = \DateTime::createFromFormat('U',$expires);if (false ===$timestampAsDateTime) {thrownew \UnexpectedValueException(sprintf('The cookie expiration time "%s" is not valid.',$expires));    }$this->expires =$timestampAsDateTime->format('U');}

@xabbuh
Copy link
MemberAuthor

@javiereguiluz I don't think so. Let me quote myself from#15656 (comment):

Actually, after thinking of this again I do not think that we need to change the constructor. It is documented that the expected value must be a string containing the expires timestamp.

The constructor will be used by some code that already had to parse theSet-Cookie header. So this part should be responsible to deal with invalid values instead of magically treating them as anything else.

Copy link
Member

@javiereguiluzjaviereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@xabbuh you are right! I missed your comment.

👍

Status: reviewed

@fabpot
Copy link
Member

Thank you@xabbuh.

@fabpotfabpot merged commitf19788d intosymfony:2.7Jan 30, 2017
fabpot added a commit that referenced this pull requestJan 30, 2017
…abbuh)This PR was merged into the 2.7 branch.Discussion----------[BrowserKit] ignore invalid cookies expires date format| Q             | A| ------------- | ---| Branch?       | 2.7| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#15656| License       | MIT| Doc PR        |Commits-------f19788d ignore invalid cookies expires date format
@xabbuhxabbuh deleted the issue-15656 branchJanuary 30, 2017 15:33
This was referencedFeb 6, 2017
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@javiereguiluzjaviereguiluzjaviereguiluz approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@xabbuh@stof@fabpot@javiereguiluz@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp