Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[HttpFoundation] Mark more methods as@final#21461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| * | ||
| * @return int|null Number of seconds | ||
| * | ||
| * @final since version 3.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Should we support the annotations on methods in the DebugClassLoader ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I guess so!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I can't do it right now, but i will asap.
| * | ||
| * @return $this | ||
| * | ||
| * @final since version 3.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Shouldn't this be3.3 everywhere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@final support is since 3.3, but the method is final since 3.2 - see deprecation in the constructor
xabbuh left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
👍
javiereguiluz left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
👍
fabpot commentedJan 30, 2017
Thank you@nicolas-grekas. |
…grekas)This PR was merged into the 3.3-dev branch.Discussion----------[HttpFoundation] Mark more methods as `@final`| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | no| BC breaks? | no| Deprecations? | yes| Tests pass? | no| Fixed tickets | -| License | MIT| Doc PR | -Follow up of#19734 (ping@GuilhemN)Commits-------84a664f [HttpFoundation] Mark more methods as `@final`
This PR was squashed before being merged into the 3.3-dev branch (closes#21465).Discussion----------[Debug] Support `@final` on methods| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#21461 (comment)| License | MIT| Doc PR |This adds support for `@final` on methods:```phpclass Foo { /** *@Final since version 2.0. */ public function bar() { }}```ping@nicolas-grekasCommits-------1b0a6b6 [Debug] Support on methods
Follow up of#19734 (ping@GuilhemN)