Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[DI] Generalize constructor autowiring to partial method calls#21404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
f8af196 to29c2fd5CompareMember
dunglas commentedJan 25, 2017
👍 |
Member
stof commentedJan 25, 2017
looks good to me |
Member
fabpot commentedJan 25, 2017
Thank you@nicolas-grekas. |
fabpot added a commit that referenced this pull requestJan 25, 2017
…od calls (nicolas-grekas)This PR was merged into the 3.3-dev branch.Discussion----------[DI] Generalize constructor autowiring to partial method calls| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | -| License | MIT| Doc PR | -When autowiring is enabled:currently, the constructor can be partially wired, and autowiring will complete the remaining missing arguments.But there is no reason this should only apply to the constructor.This PR fixes this inconsistency by looking at all method calls, and wire missing arguments in the same way.Commits-------29c2fd5 [DI] Generalize constructor autowiring to partial method calls
Merged
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When autowiring is enabled:
currently, the constructor can be partially wired, and autowiring will complete the remaining missing arguments.
But there is no reason this should only apply to the constructor.
This PR fixes this inconsistency by looking at all method calls, and wire missing arguments in the same way.