Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Debug] Deprecate ContextErrorException#21388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
stof commentedJan 24, 2017
👍 Btw, it would be great to fix the deps=high failures in the VarDumper component |
fabpot commentedJan 24, 2017
Thank you@nicolas-grekas. |
This PR was merged into the 3.3-dev branch.Discussion----------[Debug] Deprecate ContextErrorException| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | no| BC breaks? | no| Deprecations? | yes| Tests pass? | yes| Fixed tickets | -| License | MIT| Doc PR | -Since the `$context` argument is going to be deprecated in PHP 7.2 (seehttps://wiki.php.net/rfc/deprecations_php_7_2#errcontext_argument_of_error_handler), let's deprecate ContextErrorException altogether.Commits-------c379707 [Debug] Deprecate ContextErrorException
| ErrorHandler::register(); | ||
| try { | ||
| self::triggerNotice($this); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The variable and comment intriggerNotice should be removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
removed in0bcc5af
This PR was merged into the 4.0-dev branch.Discussion----------[Debug] Removed ContextErrorException| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | no| BC breaks? | yes| Deprecations? | no| Tests pass? | yes| Fixed tickets |#21388| License | MIT| Doc PR | n/aCommits-------76dc317 Removed ContextErrorException
Uh oh!
There was an error while loading.Please reload this page.
Since the
$contextargument is going to be deprecated in PHP 7.2 (seehttps://wiki.php.net/rfc/deprecations_php_7_2#errcontext_argument_of_error_handler), let's deprecate ContextErrorException altogether.