We could still deprecate this feature in 3.3 as it's inconsistent with other loaders, properly defining attributes is always better IMHO.

Can you add a test-case with the(Request $request = null) and a test with a controller like this (viaWebTestCase) to prevent regressions?

What to do about the feature regarding defaults?

• it should be kept as is
• it should be removed
• it should be added to the other loaders as well

What to do about the feature regarding defaults?

IMHO it should be removed, at least not kept as is, switching between two config formats for routing should not break an app.

Can you add a test-case with the (Request $request = null) and a test with a controller like this (via WebTestCase) to prevent regressions?

Sure!
Status: needs work

IMHO it should be removed, at least not kept as is, switching between two config formats for routing should not break an app.

Removing it makes sense, but it must be done using a deprecation first (so deprecated in 3.3 and removed in 4.0)

Functional test added. Hope the fix is good, it was not that easy 😄

Status: needs review

Not sure we should deprecate the feature, I think it's a nice one.

I can understand. I'll look at adding it to other formats on 3.3 if you agree

Build failure is normal (high deps only).

Thank you@chalasr.

This is still a BC break as demonstrated by the tests of FrameworkExtraBundle:https://travis-ci.org/sensiolabs/SensioFrameworkExtraBundle/jobs/197153674

@chalasr Can you have a look at this?

/**     * @Route("/simple/multiple/{a}/{b}/")     * @Template("@Foo/Simple/some.html.twig")     */publicfunctionsomeMoreAction($a,$b,$c ='c')    {    }

expectation ishenk, bar, c as{c} is not provided. Result ishenk, bar,.$c appears to be empty while it should getc as value.

I'll look into it.

Reproduced on our test case in 2.7 and 3.3 (master...chalasr:reproduce-sensioextra-test) all is fine for argument resolving.

The bottleneck seems to be in theTemplate annotation handling which relies on request attributes to resolve template vars:https://github.com/sensiolabs/SensioFrameworkExtraBundle/blob/3.0/EventListener/TemplateListener.php#L153.
Since we no longer set request attributes for arguments that are not expected in the route path (because it was buggy), the test is failing.
I think it should be solved on the SensioFrameworkExtraBundle by making it inject vars from both request attributes and method argument defaults.
Let me know what do you think, anyway I'll open a PR on SensioFrameworkExtraBundle later today so you can judge.

@fabpot Seesensiolabs/SensioFrameworkExtraBundle#456