Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[FrameworkBundle] Execute the PhpDocExtractor earlier#21370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
nicolas-grekas commentedJan 24, 2017
Not sure it should go on master to me. To reviewers: please advise your pov :) |
GuilhemN commentedJan 24, 2017
@nicolas-grekas do you think it should go in 2.8? It is fine for me either way. |
xabbuh commentedJan 30, 2017
Looks like a bug fix to me. |
fabpot commentedJan 30, 2017
@dunglas's comment on the issue is interesting; it was done for performance reasons. This change makes sense but can we check that performance is still ok? |
GuilhemN commentedJan 30, 2017 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@fabpot that's why there is a cache layer, i don't think it's relevant. |
fabpot commentedJan 30, 2017
Thank you@GuilhemN. |
…lhemN)This PR was submitted for the master branch but it was merged into the 2.8 branch instead (closes#21370).Discussion----------[FrameworkBundle] Execute the PhpDocExtractor earlier| Q | A| ------------- | ---| Branch? | master| Bug fix? | yes, but safer to apply on master| New feature? | no| BC breaks? | is changing a priority a bc break?| Deprecations? | no| Tests pass? | yes| Fixed tickets |#21367| License | MIT| Doc PR |Fixes#21367.> I wonder if this is logical to execute the PhpDocExtractor after the ReflectionExtractor: when you use phpdocs it's because they are more precise than php type hints.This causes an issue in NelmioApiDocBundle, for example you can't use int[] with a setter as the type mixed[] will be returned instead of int[].>> ~~Would you accept bumping its priority to -999?~~This PR changes the priority of the `ReflectionExtractor` to `-1002` to make sure it is executed after the `PhpDocExtractor`.Commits-------0425e05 [FrameworkBundle] Execute the PhpDocExtractor earlier
This PR was merged into the 3.3-dev branch.Discussion----------[FrameworkBundle] Fix tests| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | n/a| License | MIT| Doc PR | n/aTravis is red because of the new test introduced in#21370. This should make it green again.Commits-------1bf451c [FrameworkBundle] Fix tests
… case (xabbuh)This PR was merged into the 2.8 branch.Discussion----------[FrameworkBundle] add missing functional Serializer test case| Q | A| ------------- | ---| Branch? | 2.8| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets || License | MIT| Doc PR |This is needed to make the test introduced in#21370. It basically backports the functional test config as introduced by@dunglas in#20480.Commits-------24243ac add missing functional Serializer test case
teohhanhui commentedMar 29, 2017
This has caused BC break in my app. 😞 |
xabbuh commentedMar 29, 2017
@teohhanhui Please open a new issue describing the BC break you experience. Here your comment will likely get lost. |
Fixes#21367.
This PR changes the priority of the
ReflectionExtractorto-1002to make sure it is executed after thePhpDocExtractor.