NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[DependencyInjection] Always autowire the constructor#21306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

fabpot merged 1 commit intosymfony:masterfromdunglas:autowiring_construct_default

Jan 16, 2017

Merged

[DependencyInjection] Always autowire the constructor#21306

fabpot merged 1 commit intosymfony:masterfromdunglas:autowiring_construct_default

Jan 16, 2017

Conversation

Copy link

Member

dunglas commentedJan 16, 2017•
edited
Loading

Q	A
Branch?	master
Bug fix?	no
New feature?	no
BC breaks?	no (because method autowiring has been introduced in 3.3)
Deprecations?	no
Tests pass?	yes
Fixed tickets	n/a
License	MIT
Doc PR	n/a

Always try to autowire the constructor even if it has not been configured explicitly. It doesn't make sense to autowire some methods but not the constructor. It will also allow to write shorter definitions when using method autowiring:

services:Foo\Bar:{ autowire: ['set*'] }

instead of

services:Foo\Bar:{ autowire: ['__construct', 'set*'] }

dunglas requested a review fromnicolas-grekas

January 16, 2017 15:19

carsonbot added Status: Needs Review DependencyInjection labels

Jan 16, 2017

dunglas force-pushed theautowiring_construct_default branch from618e2fe to3dc98ceCompare

January 16, 2017 15:20

[DependencyInjection] Always autowire the constructor

be3d11f

dunglas force-pushed theautowiring_construct_default branch from3dc98ce tobe3d11fCompare

January 16, 2017 15:27

nicolas-grekas approved these changes

Jan 16, 2017

View reviewed changes

Copy link

Member

nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

👍

nicolas-grekas added this to the3.3 milestone

Jan 16, 2017

Simperfit approved these changes

Jan 16, 2017

View reviewed changes

Copy link

Member

fabpot commentedJan 16, 2017

Looks like a slippery slope here :)

What if my config is:

services:    Foo\Bar: { autowire: ['setLogger'] }

Copy link

MemberAuthor

dunglas commentedJan 16, 2017•
edited
Loading

The constructor will be autowired if it exists. If it's not wanted, it's weird to useautowire instead of acall.

Copy link

Member

nicolas-grekas commentedJan 16, 2017

I agree with@dunglas: autowiring has to wire the constructor - and optionally the setters.
Having to state:

services:Foo\Bar:{ autowire: ['__construct', 'setLogger'] }

looks like unneeded boilerplate to me, that people will forget most of the time. There is always a constructor to wire. We don't need to handle the case for one wanting to autowire the setters but wire manually the contructor, because by doing so, one already went out of autowire-land.

Copy link

Member

fabpot commentedJan 16, 2017

Thank you@dunglas.

fabpot merged commitbe3d11f intosymfony:master

Jan 16, 2017

fabpot added a commit that referenced this pull request

Jan 16, 2017

feature#21306[DependencyInjection] Always autowire the constructor …

f8b02ed

…(dunglas)This PR was merged into the 3.3-dev branch.Discussion----------[DependencyInjection] Always autowire the constructor| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | no| BC breaks?    | no (because method autowiring has been introduced in 3.3)| Deprecations? | no| Tests pass?   | yes| Fixed tickets | n/a| License       | MIT| Doc PR        | n/aAlways try to autowire the constructor even if it has not been configured explicitly. It doesn't make sense to autowire some methods but not the constructor. It will also allow to write shorter definitions when using method autowiring:```yamlservices:    Foo\Bar: { autowire: ['set*'] }```instead of```yamlservices:    Foo\Bar: { autowire: ['__construct', 'set*'] }```Commits-------be3d11f [DependencyInjection] Always autowire the constructor