Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Ldap] Ldap username case fix#21291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
quentinus95 wants to merge2 commits intosymfony:masterfromquentinus95:ldap-case-fix
Closed

[Ldap] Ldap username case fix#21291

quentinus95 wants to merge2 commits intosymfony:masterfromquentinus95:ldap-case-fix

Conversation

@quentinus95
Copy link
Contributor

@quentinus95quentinus95 commentedJan 14, 2017•
edited by nicolas-grekas
Loading

QA
Branch?3.1
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#20486
LicenseMIT
Doc PR

@quentinus95
Copy link
ContributorAuthor

@csarrazi I have recreated a new PR and deleted the old one because I merged the whole master branch in it inadvertently (I forgot it was based on 3.1)

I have removed thenull check ingetAttributeValue method and set a default value for$uidKey ifnull given. I also set the password tonull if the password attribute isnull.

@quentinus95quentinus95 changed the titleLdap case fix[Ldap] Ldap username case fixJan 14, 2017
@nicolas-grekas
Copy link
Member

Which branch is this fix for? There's a mismatch between the description and the selected base branch (no need to change because we can while merging.)

@quentinus95
Copy link
ContributorAuthor

This fix is for the 3.1 branch, sorry!

@nicolas-grekasnicolas-grekas added this to the3.1 milestoneJan 16, 2017
@nicolas-grekas
Copy link
Member

ping@csarrazi (3.1 is EOLed in two weeks)

@csarrazi
Copy link
Contributor

csarrazi commentedJan 16, 2017•
edited
Loading

👍 , as I said in the previous PR. I would merge it against 3.1, as we still support it (even though EOL is in 2 weeks).

@quentinus95
Copy link
ContributorAuthor

Should I care about the failure on AppVeyor as it does not seems related to the changes of this PR ?

@fabpot
Copy link
Member

Thank you@quentinus95.

fabpot added a commit that referenced this pull requestJan 17, 2017
This PR was submitted for the master branch but it was merged into the 3.1 branch instead (closes#21291).Discussion----------[Ldap] Ldap username case fix| Q             | A| ------------- | ---| Branch?       | 3.1| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#20486| License       | MIT| Doc PR        |Commits-------c91689b [Ldap] Using Ldap stored username instead of form submitted one6641b79 [Ldap] load users with the good username case
@fabpotfabpot closed thisJan 17, 2017
@fabpotfabpot mentioned this pull requestJan 28, 2017
@fabpotfabpot mentioned this pull requestFeb 6, 2017
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

3.1

Development

Successfully merging this pull request may close these issues.

5 participants

@quentinus95@nicolas-grekas@csarrazi@fabpot@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp