Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[FrameworkBundle] Fix debug:container --show-arguments missing cases#21290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@chalasr
Copy link
Member

@chalasrchalasr commentedJan 14, 2017
edited
Loading

QA
Branch?3.3
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#20861 (comment)
LicenseMIT
Doc PRn/a

Fixes the new--show-arguments option for per-service describing
(i.e.debug:container foo_service --show-arguments, doesn't work at all right now).

@chalasrchalasrforce-pushed thedebug-container/fix-show-arguments branch from7ee5a3d to57b17f4CompareJanuary 14, 2017 14:39
@nicolas-grekas
Copy link
Member

ping@Cydonia7

@chalasr
Copy link
MemberAuthor

To reproduce:debug:container service-name --show-arguments --format xml|md|json|txt on the current master

@Cydonia7
Copy link
Contributor

Thank you for fixing this. To be honest, I don't understand this part of the code that well and did not think of testing per-service.

I'm 👍 on this, the tests look good and are passing.

@fabpot
Copy link
Member

Thank you@chalasr.

@fabpotfabpot merged commit57b17f4 intosymfony:masterJan 15, 2017
fabpot added a commit that referenced this pull requestJan 15, 2017
… missing cases (chalasr)This PR was merged into the 3.3-dev branch.Discussion----------[FrameworkBundle] Fix debug:container --show-arguments missing cases| Q             | A| ------------- | ---| Branch?       | 3.3| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#20861 (comment)| License       | MIT| Doc PR        | n/aFixes the new `--show-arguments` option for per-service describing(i.e. `debug:container foo_service --show-arguments`, doesn't work at all right now).Commits-------57b17f4 [FrameworkBundle] Fix debug:container --show-arguments missing cases
@chalasrchalasr deleted the debug-container/fix-show-arguments branchJanuary 15, 2017 17:05
@fabpotfabpot mentioned this pull requestMay 1, 2017
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@chalasr@nicolas-grekas@Cydonia7@fabpot@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp