Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[TwigBridge][Worklow] Added a new workflow_has_place function#21253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Member
stof commentedJan 12, 2017
what about |
MemberAuthor
lyrixx commentedJan 12, 2017
@stof I totally agree with you. I have updated the code. |
Member
fabpot commentedJan 12, 2017
Thank you@lyrixx. |
fabpot added a commit that referenced this pull requestJan 12, 2017
…unction (Padam87, lyrixx)This PR was merged into the 3.3-dev branch.Discussion----------[TwigBridge][Worklow] Added a new workflow_has_place function| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#20781| License | MIT| Doc PR |---This PR follow up#20781I also increased the Coverage of the WorkflowExtension and finally I added an extra commit that is not related to clean-up 2 unused propertiesCommits-------108c89d [TwigBridge] Removed unused class property77f820e [TwigBridge][Workflow] Added more tests on WorkflowExtensionefe500d [TwigBridge][Workflow] Fixed code and tests4d0cc68 [TwigBridge][Workflow] Added workflow_has_place twig function
MemberAuthor
lyrixx commentedJan 12, 2017
and thank you@Padam87 ;) |
Merged
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
This PR follow up#20781
I also increased the Coverage of the WorkflowExtension and finally I added an extra commit that is not related to clean-up 2 unused properties