Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[FrameworkBundle] Prevent an error when the console component isn't installed#21248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:masterfromdunglas:console_optional
Jan 12, 2017

Conversation

@dunglas
Copy link
Member

@dunglasdunglas commentedJan 12, 2017•
edited
Loading

QA
Branch?master
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#21246
LicenseMIT
Doc PRn/a

Finish#19443. Alternative to#21246.

@stof
Copy link
Member

you need to add the conflict rule too. Otherwise, we could end up in a case where we have framework-bundle 3.3 with console 2.2, where a BC break would happen: existing console commands would not be registered anymore

@dunglas
Copy link
MemberAuthor

@dunglas
Copy link
MemberAuthor

dunglas commentedJan 12, 2017•
edited
Loading

(AppVeyor error due to a timeout, Travis should become green after the merge)

@stof
Copy link
Member

then 👍

@xabbuh
Copy link
Member

👍

@fabpot
Copy link
Member

Thank you@dunglas.

@fabpotfabpot merged commitab133ca intosymfony:masterJan 12, 2017
fabpot added a commit that referenced this pull requestJan 12, 2017
…ent isn't installed (dunglas)This PR was merged into the 3.3-dev branch.Discussion----------[FrameworkBundle] Prevent an error when the console component isn't installed| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#21246| License       | MIT| Doc PR        |n/aFinish#19443. Alternative to#21246.Commits-------ab133ca [FrameworkBundle] Prevent an error when the console component isn't installed
@dunglasdunglas deleted the console_optional branchJanuary 12, 2017 20:11
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@stofstofAwaiting requested review from stof

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@dunglas@stof@xabbuh@fabpot@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp