Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[FrameworkBundle] allow to reference files directly from kernel.root_dir#21231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
…om kernel.root_dir (fabpot)This PR was merged into the 3.3-dev branch.Discussion----------[FrameworkBundle] allow to reference files directly from kernel.root_dir| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | n/a| License | MIT| Doc PR | n/aWhile working on a bundleless app, I want to be able to reference a directory for routing annotations like this:```yamlapp: resource: "../src/Controller/" type: annotation```but that does not work because Symfony expects a bundle resource (`@AppBundle...`) or a directory referenced from the main app `Resources` directory. But as I don't have such a directory, even using `../../src/Controller` does not work.So, I propose to add the %kernel.root_dir% to the list of allowed directories.By the way, we don't have the same issue with the routing annotation **file** loader as it does not use the locator for whatever reason. Should we fix it?Commits-------80b61e9 [FrameworkBundle] allowed to reference files directly from kernel.root_dir
dunglas commentedJan 10, 2017
ping@theofidry. We already stumbled on that, this patch will definitely help. |
theofidry commentedJan 10, 2017
Indeed, cf.symfony/symfony-docs#7228 |
theofidry commentedJan 10, 2017
@dunglas not sure this solve the issue completely though, as mine was due to removing |
fabpot commentedJan 10, 2017
@theofidry I don't have an |
theofidry commentedJan 11, 2017
👍 perfect then, it gave me a lot of trouble so thanks for it |
stof commentedJan 13, 2017
Shouldn't the path be relative to the location of the current file instead, to be consistent with other places in Symfony |
Tobion commentedJan 18, 2017
I agree with@stof that this makes more sense. |
While working on a bundleless app, I want to be able to reference a directory for routing annotations like this:
but that does not work because Symfony expects a bundle resource (
@AppBundle...) or a directory referenced from the main appResourcesdirectory. But as I don't have such a directory, even using../../src/Controllerdoes not work.So, I propose to add the %kernel.root_dir% to the list of allowed directories.
By the way, we don't have the same issue with the routing annotationfile loader as it does not use the locator for whatever reason. Should we fix it?