Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Yaml] Remove internal arguments from the api#21230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
nicolas-grekas commentedJan 10, 2017
Not sure this should be done in a separate PR: it belongs to#21194, and misses a BC layer |
xabbuh commentedJan 10, 2017
I think it's okay to handle it in a separate PR, but it indeed misses the BC layer and should be documented in the upgrade files. |
nicolas-grekas commentedJan 10, 2017
A separate PR will create useless conflicts with#21194, if we happen to pass the array of tag resolvers I was talking about there, but as you want of course. |
GuilhemN commentedJan 10, 2017 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
As I would have to upgrade the bc layer in#21194, I'll do it directly in it. I opened this a bit too quickly 😐 |
This PR was squashed before being merged into the 3.3-dev branch (closes#21350).Discussion----------[Yaml] Remove internal arguments from the api| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | no| BC breaks? | no| Deprecations? | yes| Tests pass? | yes| Fixed tickets |#21230| License | MIT| Doc PR |Reopening of#21230 because of [@xabbuh's comment](#21194 (comment)).> This PR removes internal constructor arguments of the `Parser` class.> This should break nothing as they are only used to build errors message and are clearly meant for internal uses.>> This would allow to have a nicer api for#21194 (comment).Commits-------ebae4ff [Yaml] Remove internal arguments from the api
This PR removes internal constructor arguments of the
Parserclass.This should break nothing as they are only used to build errors message and are clearly meant for internal uses.
This would allow to have a nicer api for#21194 (comment).