NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[Validator] do not guess getter method names#21115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

fabpot merged 1 commit intosymfony:2.7fromxabbuh:issue-18700

Feb 19, 2017

Merged

[Validator] do not guess getter method names#21115

fabpot merged 1 commit intosymfony:2.7fromxabbuh:issue-18700

Feb 19, 2017

Conversation

Copy link

Member

xabbuh commentedDec 31, 2016•
edited
Loading

Q	A
Branch?	2.7
Bug fix?	yes
New feature?	no
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets	#5219,#18700
License	MIT
Doc PR	TODO

carsonbot added Status: Needs Review Validator Bug labels

Dec 31, 2016

xabbuh mentioned this pull request

Dec 31, 2016

Bug with constraint attach to a field ( using @Assert\True() annotation )#18700

Closed

xabbuh added this to the2.7 milestone

Dec 31, 2016

Copy link

MemberAuthor

xabbuh commentedJan 2, 2017

Actually, I think that changes made to theXMLFileLoader and theYamlFileLoader should be moved into a different PR targetingmaster as a new feature.

dunglas reviewed

Jan 6, 2017

View reviewed changes

src/Symfony/Component/Validator/Mapping/ClassMetadata.php Outdated

		* @return $this
		*/
		publicfunctionaddGetterConstraint($property,Constraint$constraint)
		publicfunctionaddGetterConstraint($property,Constraint$constraint,$method =null)

Copy link

Member

dunglasJan 6, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Isn't this a BC break?

Copy link

MemberAuthor

xabbuhJan 7, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

You are right. I have added new methods instead.

xabbuh added Status: Needs Work and removed Status: Needs Review labels

Jan 7, 2017

[Validator] do not guess getter method names

bd3a90a

xabbuh force-pushed theissue-18700 branch from7a567aa tobd3a90aCompare

January 7, 2017 08:40

Copy link

MemberAuthor

xabbuh commentedJan 7, 2017

I also reverted the changes to theYamlFileLoader andXmlFileLoader as they are not needed to fix the issue reported in#18700 and qualify as new features instead.

Status: Needs Review

carsonbot added Status: Needs Review and removed Status: Needs Work labels

Jan 7, 2017

Copy link

MemberAuthor

xabbuh commentedJan 27, 2017

ping @symfony/deciders

Copy link

Member

fabpot commentedFeb 19, 2017

Thank you@xabbuh.

fabpot merged commitbd3a90a intosymfony:2.7

Feb 19, 2017

fabpot added a commit that referenced this pull request

Feb 19, 2017

bug#21115[Validator] do not guess getter method names (xabbuh)

eb0ffaa

This PR was merged into the 2.7 branch.Discussion----------[Validator] do not guess getter method names| Q             | A| ------------- | ---| Branch?       | 2.7| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#5219,#18700| License       | MIT| Doc PR        | TODOCommits-------bd3a90a [Validator] do not guess getter method names

xabbuh deleted the issue-18700 branch

February 20, 2017 06:41

This was referencedMar 6, 2017

Release v2.7.25#21884

Merged

Release v2.8.18#21885

Merged

Release v3.2.5#21939

Merged

teohhanhui reviewed

Mar 14, 2017

View reviewed changes

src/Symfony/Component/Validator/Mapping/ClassMetadata.php

		* @param Constraint $constraint The constraint
		* @param string $property The name of the property
		* @param Constraint $constraint The constraint
		* @param string\|null $method The method that is called to retrieve the value being validated (null for auto-detection)

Copy link

Contributor

teohhanhuiMar 14, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Wrong PHPDoc.

Copy link

MemberAuthor

xabbuhMar 14, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

good catch, see#21993

xabbuh mentioned this pull request

Mar 14, 2017

[Validator] revert wrong Phpdoc change#21993

Merged

nicolas-grekas added a commit that referenced this pull request

Mar 14, 2017

minor#21993[Validator] revert wrong Phpdoc change (xabbuh)

71b2c3a

This PR was merged into the 2.7 branch.Discussion----------[Validator] revert wrong Phpdoc change| Q             | A| ------------- | ---| Branch?       | 2.7| Bug fix?      | no| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#21115 (comment)| License       | MIT| Doc PR        |Commits-------86e8afa [Validator] revert wrong Phpdoc change