Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[PhpUnitBridge] run PHPUnit in the same process#21112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
xabbuh commentedDec 31, 2016
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #21083 |
| License | MIT |
| Doc PR |
xabbuh commentedDec 31, 2016
@julienfalque Can you check if this change solves the issue you described in#21083 (comment) too? |
nicolas-grekas commentedDec 31, 2016
This currently breaks the handling of the exit code (see var $exit). Otherwise I think that's a good way to go. Maybe see if we can do something with OK/KO in a shutdown function ? Or deal with it in .travis.yml file as it was done before. |
9c678fe to02ef903Comparexabbuh commentedDec 31, 2016
Unfortunately, we cannot detect the exit code inside a shutdown function. So we will need to update our Travis CI config after this has been merged. |
| } | ||
| include"$PHPUNIT_DIR/phpunit-$PHPUNIT_VERSION/phpunit"; | ||
| if (!file_exists($component =array_pop($argv))) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Can be removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
oops, good catch
02ef903 to1986278Comparejulienfalque commentedJan 2, 2017
@xabbuh I confirm this solves my issue too :) |
xabbuh commentedJan 2, 2017
@julienfalque Thanks! Happy new year to you! 🎉 |
julienfalque commentedJan 2, 2017
Happy new year :) 🎉 |
nicolas-grekas commentedJan 2, 2017
👍 |
fabpot commentedJan 2, 2017
Thank you@xabbuh. |
This PR was merged into the 3.3-dev branch.Discussion----------[PhpUnitBridge] run PHPUnit in the same process| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#21083| License | MIT| Doc PR |Commits-------1986278 [PhpUnitBridge] run PHPUnit in the same process