Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[FrameworkBundle] fix IPv6 address handling in server commands#21104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:2.7fromxabbuh:ipv6-server-address
Jan 12, 2017

Conversation

@xabbuh
Copy link
Member

QA
Branch?2.7
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#21039 (comment)
LicenseMIT
Doc PR

Thisfixes#21039 (comment) as reported by@sstok for the existing commands by backporting@fabpot's patch from#21039.

@staabm
Copy link
Contributor

Misses test?

@xabbuh
Copy link
MemberAuthor

In fact, we do not have any tests for the server commands at all. Not sure we should add some (their implementation might become tricky).

@GromNaN
Copy link
Member

GromNaN commentedDec 30, 2016•
edited
Loading

The method that parses the<ip>:<port> could be extracted toSymfony\Component\HttpFoundation\IpUtils and unit tested.

chalasr and sstok reacted with thumbs up emoji

@xabbuhxabbuh added this to the2.7 milestoneDec 31, 2016
@nicolas-grekas
Copy link
Member

Thank you@xabbuh.

@nicolas-grekasnicolas-grekas merged commit2bb4713 intosymfony:2.7Jan 12, 2017
nicolas-grekas added a commit that referenced this pull requestJan 12, 2017
…ands (xabbuh)This PR was merged into the 2.7 branch.Discussion----------[FrameworkBundle] fix IPv6 address handling in server commands| Q             | A| ------------- | ---| Branch?       | 2.7| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#21039 (comment)| License       | MIT| Doc PR        |Thisfixes#21039 (comment) as reported by@sstok for the existing commands by backporting@fabpot's patch from#21039.Commits-------2bb4713 fix IPv6 address handling in server commands
@xabbuhxabbuh deleted the ipv6-server-address branchJanuary 12, 2017 13:40
This was referencedJan 12, 2017
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

2.7

Development

Successfully merging this pull request may close these issues.

5 participants

@xabbuh@staabm@GromNaN@nicolas-grekas@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp