Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
fixed @return when returning this or static#21059
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| * @param TableStyle|string $name The style name or a TableStyle instance | ||
| * | ||
| * @returnTable | ||
| * @returnself |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
$this
| * @param bool $shared Whether the service must be shared or not | ||
| * | ||
| * @returnDefinition The current instance | ||
| * @returnself |
ogizanagiDec 27, 2016 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
$this (same for each changes in this class)
This PR was merged into the 2.8 branch.Discussion----------fixed@return when returning this or static| Q | A| ------------- | ---| Branch? | 2.8| Bug fix? | no| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | n/a| License | MIT| Doc PR | n/aFollow-up of#21054 for the 2.8 branch.Commits-------7808b67 fixed@return when returning this or static
ogizanagi commentedDec 29, 2016
…agi)This PR was merged into the 2.8 branch.Discussion----------Fixed@return when returning this or static #bis| Q | A| ------------- | ---| Branch? | 2.8| Bug fix? | no| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | N/A| License | MIT| Doc PR | N/AFor some reasons these weren't fixed before#21059 was merged despite the review comments 😆Commits-------20d8c74 Fixed@return when returning this or static #bis
Follow-up of#21054 for the 2.8 branch.