NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[DI] deprecate the strict attribute#21058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

fabpot merged 1 commit intosymfony:masterfromxabbuh:pr-20938

Jan 30, 2017

Merged

[DI] deprecate the strict attribute#21058

fabpot merged 1 commit intosymfony:masterfromxabbuh:pr-20938

Jan 30, 2017

Conversation

Copy link

Member

xabbuh commentedDec 27, 2016

Q	A
Branch?	master
Bug fix?	no
New feature?	no
BC breaks?	no
Deprecations?	yes
Tests pass?	yes
Fixed tickets	#20938 (comment)
License	MIT
Doc PR

carsonbot added Status: Needs Review DependencyInjection Deprecation labels

Dec 27, 2016

xabbuh mentioned this pull request

Dec 27, 2016

[DI] Prepare dropping "strict" handling in loaders#20938

Merged

Copy link

Member

nicolas-grekas commentedDec 27, 2016

My concerns are here:#20938 (comment)
So if you considered them but still think this should be the way to go, I'm OK.
(which means I'm +0 :) )

nicolas-grekas added this to the3.3 milestone

Dec 27, 2016

[DI] deprecate the strict attribute

49cb4db

xabbuh force-pushed thepr-20938 branch fromc887179 to49cb4dbCompare

January 30, 2017 14:47

Copy link

Member

nicolas-grekas commentedJan 30, 2017

👍
if bundles need to support SF 2 & 4 and are bothered about this "strict" attribute, they can very well have two different xml files.

Copy link

Member

if they need to support both 2.x and 4.x, they cannot rely on thestrict=false feature anyway (as it is always string in Symfony 3+), and so they can omit the attribute even in 2.x (as the default behavior of 2.x is the one we kept).

👍 about this.

Copy link

Member

fabpot commentedJan 30, 2017

Thank you@xabbuh.

fabpot merged commit49cb4db intosymfony:master

Jan 30, 2017

fabpot added a commit that referenced this pull request

Jan 30, 2017

minor#21058[DI] deprecate the strict attribute (xabbuh)

5e5a88c

This PR was merged into the 3.3-dev branch.Discussion----------[DI] deprecate the strict attribute| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | no| BC breaks?    | no| Deprecations? | yes| Tests pass?   | yes| Fixed tickets |#20938 (comment)| License       | MIT| Doc PR        |Commits-------49cb4db [DI] deprecate the strict attribute

xabbuh deleted the pr-20938 branch

January 30, 2017 15:31

dbu mentioned this pull request

Feb 18, 2017

add missing changelog for deprecated strict attribute#21662

Merged

fabpot added a commit that referenced this pull request

Feb 20, 2017

minor#21662add missing changelog for deprecated strict attribute (dbu)

fd65bcc

This PR was merged into the 3.3-dev branch.Discussion----------add missing changelog for deprecated strict attribute| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets | -| License       | MIT| Doc PR        | -since#21058, 3.3 triggers a deprecation when using the strict attribute. luckily wouter managed to find the reason and we figured out we can simply delete the attribute. having an upgrade file entry would make it easier to find the reason for the deprecation and be sure what to do. (assuming i understood the implications correctly)Commits-------2c5f879 add missing changelog for deprecated strict attribute