Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Config] Improve PHPdoc / IDE autocomplete#21047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:2.7fromro0NL:config/phpdoc
Dec 28, 2016
Merged

[Config] Improve PHPdoc / IDE autocomplete#21047

nicolas-grekas merged 1 commit intosymfony:2.7fromro0NL:config/phpdoc
Dec 28, 2016

Conversation

@ro0NL
Copy link
Contributor

@ro0NLro0NL commentedDec 25, 2016
edited
Loading

QA
Branch?2.7
Bug fix?yes-ish
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#...
LicenseMIT
Doc PRsymfony/symfony-docs#...

The missing pieces for fixing the autocomplete in IDE's (tested inPhpStorm 2016.3.2).

Each method seems to be found now for the framework bundle configuration 😱

Actually uses#20923 where needed, but i think we should go with it consistently.

Relates to#20290 (comment)

* phase, it's default value will be derived from its children default values.
*
* @returnArrayNodeDefinition
* @return$this
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Should probably fixed consistently (see also#20290).

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Happening :) lets see if any remain after#21054

@nicolas-grekas
Copy link
Member

I'd be in favor of moving this to a lower branch.

@ro0NL
Copy link
ContributorAuthor

Agree.. ill try rebasing 2.7 somewhere today.

@ro0NLro0NL changed the base branch frommaster to2.7December 27, 2016 15:12
@nicolas-grekas
Copy link
Member

Thank you@ro0NL.

@nicolas-grekasnicolas-grekas merged commit3f3c6e0 intosymfony:2.7Dec 28, 2016
nicolas-grekas added a commit that referenced this pull requestDec 28, 2016
This PR was merged into the 2.7 branch.Discussion----------[Config] Improve PHPdoc / IDE autocomplete| Q             | A| ------------- | ---| Branch?       | 2.7| Bug fix?      | yes-ish| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets | #... <!-- #-prefixed issue number(s), if any -->| License       | MIT| Doc PR        | symfony/symfony-docs#... <!--highly recommended for new features-->The missing pieces for fixing the autocomplete in IDE's (tested in `PhpStorm 2016.3.2`).Each method seems to be found now for the framework bundle configuration 😱Actually uses#20923 where needed, but i think we should go with it consistently.Relates to#20290 (comment)Commits-------3f3c6e0 [Config] Improve PHPdoc / IDE autocomplete
@ro0NLro0NL deleted the config/phpdoc branchDecember 28, 2016 08:19
fabpot added a commit that referenced this pull requestApr 1, 2019
…ee builder (Koc)This PR was merged into the 4.2 branch.Discussion----------[Config] Improve PHPdoc / IDE autocomplete for config tree builder| Q             | A| ------------- | ---| Branch?       | 4.2| Bug fix?      | no| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets | -| License       | MIT| Doc PR        | -follow up of#27476 and#21047Commits-------21f7977 Improve PHPdoc / IDE autocomplete for config tree builder
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@xabbuhxabbuhxabbuh left review comments

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ro0NL@nicolas-grekas@xabbuh@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp