Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[WebProfilerBundle] Added preview iframe for built-in IDE links#21045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
ro0NL wants to merge1 commit intosymfony:masterfromro0NL:wdt/ide-iframe-links
Closed

[WebProfilerBundle] Added preview iframe for built-in IDE links#21045

ro0NL wants to merge1 commit intosymfony:masterfromro0NL:wdt/ide-iframe-links

Conversation

@ro0NL
Copy link
Contributor

@ro0NLro0NL commentedDec 24, 2016
edited
Loading

QA
Branch?master
Bug fix?no
New feature?yes
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#19973 (comment)
LicenseMIT
Doc PRsymfony/symfony-docs#...

I was playing with this a few days ago.. and i just finished it. I really like it :)

out

maidmaid reacted with thumbs up emoji
@ro0NL
Copy link
ContributorAuthor

Given#21050 (comment) im not really sure about this. It could be too much, the experience is nice though.

The approach is simple.. but you can do it easily (custom) in your own projects. Code is here to take 👍

Closing for now.

@ro0NLro0NL closed thisDec 26, 2016
@ro0NLro0NL deleted the wdt/ide-iframe-links branchDecember 26, 2016 12:08
@ogizanagi
Copy link
Contributor

ogizanagi commentedDec 26, 2016
edited
Loading

@ro0NL : Just to mention: I played a little around with the web profiler in a similar way a while ago, in order to make the whole profiler panel displayable in an iframe, which is pretty convenient to introspect what happens on the current page without leaving it/opening a new tab.
But as you said, I'm not sure it is worth being in the Symfony core, as it is easily achievable by tweaking your project or making a little browser extension, and the benefits are almost only about saving aCTRL /CMD+clic.

@ro0NL
Copy link
ContributorAuthor

the benefits are almost only about saving a CTRL / CMD+clic

And switching tabs/windows, which can be huge in terms of experience / doing it many times each day.

@ro0NL
Copy link
ContributorAuthor

ro0NL commentedDec 26, 2016
edited
Loading

Btw if we could do 50/50 split screen with the profiler, you'd really make my day.

This code snippet could work for both.. but i dont know how you did it? Was it less "complex".. better?

Having it built-in could be marketing-wise a smart move actually.

@ogizanagi
Copy link
Contributor

ogizanagi commentedDec 26, 2016
edited
Loading

Unfortunately, I think I don't have this snippet anymore. Anyway it was done at the time the 2.7 version was released, so it'll needs some styling tweaks.

But the solution is nothing more or less complex than yours, simply exposing the whole profiler in an iframe.
If it makes sense to a majority, I or anyone else could easily replicate it (more advanced features like being able to navigate within very simply (backwards and forwards using history) would be great too).

@ro0NL
Copy link
ContributorAuthor

ro0NL commentedDec 26, 2016
edited
Loading

@javiereguiluz WDYT? Does it solve a case? (considering we can do this for the whole profiler).

I understand devs most of the time live with their editor anyway.. so perhaps only this feature brings little value (other then better experienceif used, imo.). But to be honest i never considered the whole profiler on this... it blew my mind actually ;-)

I could definitely appreciate such a feature! But we shouldnt do it only because it looks pretty or so.. (but yeah.. marketing-wise that also could be a smart move ;-)).

Btw. we already haveset/getPreference. So we can always make things easy opt-int or opt-out.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ro0NL@ogizanagi@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp