you also need to deprecate the TwigEngine (in the bridge and the bundle), as they are about integrating Twig in this component.

And this requires deprecating theAppBundle:foo:bar.html.twig syntax too, as it comes from the Templating system (and this one is used)

Do we want to deprecate this syntax or not?

Well, if we don't want to deprecate it, you need to undeprecate the TemplateNameParser system in your PR.

The@AppBundle/foo/bar.html.twig syntax is recommended since 2.5 or something like that.
But deprecating the symfony specific syntax might show some resistance :P

So let's deprecate this notation.

@dunglas last time we tried to deprecate that syntax (in June 2014) they almost killed us 😁 See#11051

By the way, in#20130 we discussed about a big inconsistency in the Twig syntax. Maybe we should take care of that too?

@javiereguiluz but we have an advantage this time, people already using Twig alone (without the templating bridge) can only use the@AppBundle syntax. We're deprecating the Templating component, other syntaxes - not supported by the Twig Bundle - will be deprecated with it. Does it looks reasonable?

Indeed,#11051 is very different. Here we are deprecatingeverything related to the Templating component, including the way we reference templates. There is no need to discuss how to reference templates as we are just using "pure" Twig, nothing more.

But I think we should indeed look into#20130 and try to find a way to resolve the inconsistency if we force everyone to use the Twig schema to reference templates.

One even more important thing: The native Twig namespace syntax as it is currently integrated in the framework fails on bundle inheritance (see#6919). Please take a look at#19586 which provides a fix.

Should the TemplatingPass be deprecated?
Maybe should it trigger deprecations for each service in the loop too (i.e. taggedtemplating.*)?

@chalasr good catch, done.

One question remains on my end : templating was giving a layer of abstraction to twig and if@templating goes away, do we need to inject@twig directly or some other component will provide an abstraction ?

Status: needs work

Thank you@dunglas.

Thanks for finishing this!

I'm trying to make the doc changes for this. I have two questions:

1. Is using PHP templates (normal templates, form themes, etc) deprecated in 4.3 and will be removed in 5.0? If not, which are the steps needed to render PHP templates in 5.0?

2. What will happen with config like this? Is deprecated too? Is there an alternative?

# config/packages/framework.yamlframework:# ...templating:hinclude_default_template:hinclude.html.twig

Thanks!

@javiereguiluz

To answer your questions (and this is just my point of view):

1. Yes, we will remove support for the PHP form themes and other PHP template support in 5.0. If people want to keep using them, we will need to find volunteers to create a new PHPTemplateBundle that bundles all deprecated classes and support files.

2. We need to fix those and see where they belongs to now.