NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[Form] Applying bug #18935 fix (done only on symfony/form)#20960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

Ghriim wants to merge1 commit intosymfony:masterfromGhriim:master

Closed

[Form] Applying bug #18935 fix (done only on symfony/form)#20960

Ghriim wants to merge1 commit intosymfony:masterfromGhriim:master

Conversation

Copy link

Ghriim commentedDec 16, 2016

Q	A
Branch?	3.2
Bug fix?	yes
New feature?	no
BC breaks?	yes (only for the behavior)
Deprecations?	no
Tests pass?	yes
Fixed tickets	symfony/form#11493
License	MIT
Doc PR	seesymfony/form@`8502f30`)

[Form] Applying bug#18935fix (done only on symfony/form, seesymfon…

ea47138

…y/form@8502f30#diff-65e060c56a6fa2c4a1f057f79b70cbb4)

carsonbot added Status: Needs Review Form Bug BC Break labels

Dec 16, 2016

Copy link

Contributor

HeahDude commentedDec 16, 2016

This is a duplicate of#18935 which has been reverted.

Sadly we cannot afford this bc break, prepopulating data in a form does not belong to the scope of its validation if it is not submitted.

Btw, calling$form->isValid() without calling$form->isSubmitted() first has been deprecated in 3.2, so this can be more consistant.

fabpot closed this

Dec 16, 2016

Copy link

Author

Ghriim commentedDec 16, 2016

I've discover this bug fix from this ticket#11493
Is their any work around for PATCH context if the fix on ViolationMapper is finally reverted ?

Copy link

Contributor

HeahDude commentedDec 16, 2016

@Ghriim$this->get('validator')->validate($form->getData()) should be enough to avoid persisting wrong data ;), but you'll have to handle errors yourself though.