NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[EventDispatcher] Deprecate ContainerAwareEventDispatcher#20937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

fabpot merged 1 commit intosymfony:masterfromnicolas-grekas:event-deprec-getcont

Jan 8, 2017

Merged

[EventDispatcher] Deprecate ContainerAwareEventDispatcher#20937

fabpot merged 1 commit intosymfony:masterfromnicolas-grekas:event-deprec-getcont

Jan 8, 2017

Conversation

Copy link

Member

nicolas-grekas commentedDec 15, 2016

Q	A
Branch?	master
Bug fix?	no
New feature?	no
BC breaks?	no
Deprecations?	yes
Tests pass?	no
Fixed tickets	-
License	MIT
Doc PR	-

These methods shouldn't be available to end users.

nicolas-grekas added this to the3.3 milestone

Dec 15, 2016

carsonbot added Status: Needs Review EventDispatcher Deprecation labels

Dec 15, 2016

Copy link

Member

stof commentedDec 15, 2016

👍

nicolas-grekas force-pushed theevent-deprec-getcont branch from0b8ac03 to3859ac0Compare

December 16, 2016 20:46

nicolas-grekas changed the title~~[EventDispatcher] Deprecate ContainerAwareEventDispatcher::getContainer() && ::lazyLoad()~~[EventDispatcher] Deprecate ContainerAwareEventDispatcher

Dec 16, 2016

Copy link

MemberAuthor

nicolas-grekas commentedDec 16, 2016

PR updated to deprecate the ContainerAwareEventDispatcher class.
To be rebased on top of#20953 before merging.

Copy link

Member

xabbuh commentedDec 17, 2016

The upgrade files for 3.3 and 4.0 need to be updated too.

nicolas-grekas added Status: Needs Work and removed Status: Needs Review labels

Dec 19, 2016

nicolas-grekas force-pushed theevent-deprec-getcont branch from3859ac0 tod0d4a12Compare

December 26, 2016 16:43

Copy link

Member

fabpot commentedJan 7, 2017

You should probably updatesrc/Symfony/Bundle/FrameworkBundle/Resources/config/services.xml as well to remove its usage.

[EventDispatcher] Deprecate ContainerAwareEventDispatcher

c4a6a8a

nicolas-grekas force-pushed theevent-deprec-getcont branch fromd0d4a12 toc4a6a8aCompare

January 7, 2017 15:58

Copy link

MemberAuthor

nicolas-grekas commentedJan 7, 2017

Rebased. About services.xml, that'd be a BC break because of the getContainer method that people may use...

nicolas-grekas added Status: Needs Review and removed Status: Needs Work labels

Jan 7, 2017

Copy link

Member

fabpot commentedJan 8, 2017

Thank you@nicolas-grekas.

fabpot merged commitc4a6a8a intosymfony:master

Jan 8, 2017

fabpot added a commit that referenced this pull request

Jan 8, 2017

feature#20937[EventDispatcher] Deprecate ContainerAwareEventDispatc…

e1d3900

…her (nicolas-grekas)This PR was merged into the 3.3-dev branch.Discussion----------[EventDispatcher] Deprecate ContainerAwareEventDispatcher| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | no| BC breaks?    | no| Deprecations? | yes| Tests pass?   | no| Fixed tickets | -| License       | MIT| Doc PR        | -These methods shouldn't be available to end users.Commits-------c4a6a8a [EventDispatcher] Deprecate ContainerAwareEventDispatcher

javiereguiluz mentioned this pull request

Jan 8, 2017

ContainerAwareEventDispatcher has been deprecatedsymfony/symfony-docs#7340

Closed

nicolas-grekas deleted the event-deprec-getcont branch

January 9, 2017 14:01

Copy link

Member

chalasr commentedFeb 14, 2017•
edited
Loading

About services.xml, that'd be a BC break because of the getContainer method that people may use...

It's a bit annoying to get deprecations each time theevent_dispatcher service is used until 4.0.
is there any alternative we can provide? Most often there is no need to callgetContainer(), only dispatching events (3rd party bundles, functional tests in final apps..)