Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[FrameworkBundle] Fix misresolved parameters in debug:config#20909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
chalasr commentedDec 13, 2016
The patch proposed by fabbot is not related to this PR thus cannot be applied. |
| privatestaticfunctionresolveParametersValues(ContainerBuilder$builder,$configs) | ||
| { | ||
| return$builder->resolveEnvPlaceholders($builder->getParameterBag()->resolveValue($configs)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Not sure about the need for this method
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I thought it could ease updating this command again after#20618, removed
nicolas-grekas commentedDec 13, 2016
Why that? I think we can apply it, wouldn't be the first time. |
5f1b505 to1d17ae2Comparechalasr commentedDec 13, 2016
From our contributing guidelines:
Applied! :) |
nicolas-grekas commentedDec 13, 2016
👍 |
1d17ae2 toc88bc89Comparefabpot commentedDec 14, 2016
Thank you@chalasr. |
This PR was merged into the 3.2 branch.Discussion----------Fix misresolved parameters in debug:config on 3.2| Q | A| ------------- | ---| Branch? | 3.2| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | n/a| License | MIT| Doc PR | n/aThis fixes parameters resolution (classic and env ones) in `debug:config`, again.Merging#20714 broke the fix resolving env parameters made in#20688, and anyway it was mismerged (#20714 was not applied when using the `path` argument, my bad, I should have prevented it).This adds a test which prevents regressions so I hope this is is the last PR on this subject.The buggy output is unfortunately part of the last 3.2 release... It can easily be confirmed by running `debug:config doctrine` on a fresh symfony-demo projectCommits-------c88bc89 Fix misresolved parameters in debug:config on 3.2
This fixes parameters resolution (classic and env ones) in
debug:config, again.Merging#20714 broke the fix resolving env parameters made in#20688, and anyway it was mismerged (#20714 was not applied when using the
pathargument, my bad, I should have prevented it).This adds a test which prevents regressions so I hope this is is the last PR on this subject.
The buggy output is unfortunately part of the last 3.2 release... It can easily be confirmed by running
debug:config doctrineon a fresh symfony-demo project