Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Console] Improve markdown format#20866
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
ogizanagi commentedDec 11, 2016 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
👍 To me it isn't a BC break, because the markdown format is not something meant to be analyzed programmatically and only intends to provide a quick documentation of the console application (I'm not even sure it'll be considered as a BC break for json actually, nor any format produced by a command is part of the BC promise). Status: Reviewed |
javiereguiluz commentedDec 11, 2016
@ogizanagi I agree that this should't be considered a BC. By the way, a while ago I thought about opening a RFC issue to discuss about removing this feature. Do people really use this Markdown descriptor? |
ro0NL commentedDec 11, 2016
It's nice API doc for a command. Ie. i would use this to generate a README.md for a command repo. |
ogizanagi commentedDec 11, 2016 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
I think it's an easy way to provide a minimalistic documentation for a tool and it is worth keeping it. I don't see as much utility for the json/xml descriptors though. I don't know what usages it deserves. Someone may try to implement a UI by parsing programmatically those formats, or maybe it can be consumed by generic worker in order to know which command to use and how to call it, but I never seen someone doing nor asking for this. |
fabpot commentedDec 11, 2016
Guys, before discussing removing something, you should assume that it was added for a reason :) The XML format is used by tools like IDEs to get information about available commands to provide a nice UI for instance. |
javiereguiluz commentedDec 11, 2016 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Yes, the XML export is useful for those cases. But what about the Markdown export? |
fabpot commentedDec 11, 2016 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
IIRC, the Markdown format has been added quite recently. So, let's dig a bit into the past PRs to see why it was added. |
ogizanagi commentedDec 11, 2016 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
ro0NL commentedDec 11, 2016
This PR only tends to improve what we already have :) (application_2.md goes from 376 to 350 lines btw). |
ro0NL commentedDec 11, 2016
What about removing |
fabpot commentedDec 13, 2016
Thank you@ro0NL. |
This PR was merged into the 3.3-dev branch.Discussion----------[Console] Improve markdown format| Q | A| ------------- | ---| Branch? | "master"| Bug fix? | no| New feature? | no| BC breaks? | not sure?| Deprecations? | no| Tests pass? | yes| Fixed tickets | comma-separated list of tickets fixed by the PR, if any| License | MIT| Doc PR | reference to the documentation PR, if anyThis improves the markdown description for a console application. To make the ouput read more friendly and intuitively (less bloated IMHO).Before:Markdown files inhttps://github.com/symfony/symfony/tree/master/src/Symfony/Component/Console/Tests/FixturesAfter:Markdown files inhttps://github.com/ro0NL/symfony/tree/console/markdown/src/Symfony/Component/Console/Tests/FixturesCommits-------302a19d [Console] Improve markdown format
javiereguiluz commentedDec 13, 2016
fabpot commentedDec 13, 2016
If the commands are hidden, I think they should not be part of the Mardown format but still be listed in the JSON or XML formats. The idea is that end users should not see them but machines should. 👍 for your other suggestions. |
ro0NL commentedDec 13, 2016 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
…rs (ogizanagi)This PR was merged into the 3.3-dev branch.Discussion----------[Console] Show hidden commands in json & xml descriptors| Q | A| ------------- | ---| Branch? | master| Bug fix? | no (may be considered, but as hidden commands did not exist before 3.2, looks more like a behavior change, hence a feature)| New feature? | yes| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#20866 (comment)| License | MIT| Doc PR | N/ACommits-------b6cf240 [Console] Show hidden commands in json & xml descriptors
…rs (ogizanagi)This PR was merged into the 3.3-dev branch.Discussion----------[Console] Show hidden commands in json & xml descriptors| Q | A| ------------- | ---| Branch? | master| Bug fix? | no (may be considered, but as hidden commands did not exist before 3.2, looks more like a behavior change, hence a feature)| New feature? | yes| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |symfony/symfony#20866 (comment)| License | MIT| Doc PR | N/ACommits-------b6cf240ab5 [Console] Show hidden commands in json & xml descriptors


Uh oh!
There was an error while loading.Please reload this page.
This improves the markdown description for a console application. To make the ouput read more friendly and intuitively (less bloated IMHO).
Before:
Markdown files inhttps://github.com/symfony/symfony/tree/master/src/Symfony/Component/Console/Tests/Fixtures
After:
Markdown files inhttps://github.com/ro0NL/symfony/tree/console/markdown/src/Symfony/Component/Console/Tests/Fixtures