NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[Routing] Mention minor BC break about UrlGenerator & query strings#20856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

fabpot merged 1 commit intosymfony:3.2fromogizanagi:upgrade/3.2/url_generator_query_string

Dec 10, 2016

Merged

[Routing] Mention minor BC break about UrlGenerator & query strings#20856

fabpot merged 1 commit intosymfony:3.2fromogizanagi:upgrade/3.2/url_generator_query_string

Dec 10, 2016

Conversation

Copy link

Contributor

ogizanagi commentedDec 10, 2016

Q	A
Branch?	3.2
Bug fix?	no
New feature?	no
BC breaks?	no, mention one
Deprecations?	no
Tests pass?	yes
Fixed tickets	N/A
License	MIT
Doc PR	N/A

Refs:

carsonbot added the Status: Needs Review label

Dec 10, 2016

ogizanagi mentioned this pull request

Dec 10, 2016

Test more PHP and Symfony versions on TravisEasyCorp/EasyAdminBundle#1421

Closed

ogizanagi changed the title~~[Router] Mention minor BC break about UrlGenerator & query strings~~[Routing] Mention minor BC break about UrlGenerator & query strings

Dec 10, 2016

[Routing] Mention minor BC break about UrlGenerator & query strings

9e73887

Simperfit approved these changes

Dec 10, 2016

View reviewed changes

Copy link

Member

fabpot commentedDec 10, 2016

Thank you@ogizanagi.

fabpot merged commit9e73887 intosymfony:3.2

Dec 10, 2016

fabpot added a commit that referenced this pull request

Dec 10, 2016

minor#20856[Routing] Mention minor BC break about UrlGenerator & qu…

c7ec4be

…ery strings (ogizanagi)This PR was merged into the 3.2 branch.Discussion----------[Routing] Mention minor BC break about UrlGenerator & query strings| Q             | A| ------------- | ---| Branch?       | 3.2| Bug fix?      | no| New feature?  | no| BC breaks?    | no, mention one| Deprecations? | no| Tests pass?   | yes| Fixed tickets | N/A| License       | MIT| Doc PR        | N/A---Refs:-https://github.com/javiereguiluz/EasyAdminBundle/pull/1421#issuecomment-266201441-#19639-http://php.net/manual/en/function.http-build-query.php-https://www.ietf.org/rfc/rfc3986.txtCommits-------9e73887 [Routing] Mention minor BC break about UrlGenerator & query strings

ogizanagi deleted the upgrade/3.2/url_generator_query_string branch

December 10, 2016 14:18