Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Validator] Fix init of YamlFileLoader::$classes for empty files#20828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@nicolas-grekas
Copy link
Member

QA
Branch?2.7
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#20761
LicenseMIT
Doc PR-

@stof
Copy link
Member

stof commentedDec 8, 2016

Would it be possible to write a test covering the actual bug (i.e. checking thatgetMappedClasses works) instead of asserting the internal property ? it would be more reliable (the class is free to do what it wants with its private property as long as the public API works fine)

@nicolas-grekas
Copy link
MemberAuthor

The property is protected, so it's a "public" side effect, which means the test is good :)

@nicolas-grekas
Copy link
MemberAuthor

@stof is this PR ok for you?

@nicolas-grekas
Copy link
MemberAuthor

Note that this PR is against 2.7.getMappedClasses exists only on 3.2

@stof
Copy link
Member

stof commentedDec 8, 2016

👍
Status: reviewed

@nicolas-grekasnicolas-grekas merged commit073a1da intosymfony:2.7Dec 8, 2016
nicolas-grekas added a commit that referenced this pull requestDec 8, 2016
… files (nicolas-grekas)This PR was merged into the 2.7 branch.Discussion----------[Validator] Fix init of YamlFileLoader::$classes for empty files| Q             | A| ------------- | ---| Branch?       | 2.7| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#20761| License       | MIT| Doc PR        | -Commits-------073a1da [Validator] Fix init of YamlFileLoader::$classes for empty files
@nicolas-grekasnicolas-grekas deleted the fix-empty-valid branchDecember 8, 2016 15:58
This was referencedDec 13, 2016
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nicolas-grekas@stof@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp